Fix portable ps command for remote process picker#14592
Conversation
|
@microsoft-github-policy-service agree |
|
@bobbrow The Linux and Windows checks are failing during dependency installation because the Azure package registry returns HTTP 503 responses (for mkdirp and each-props respectively). The macOS check passed, and neither failing job reached the build or the changed code. I attempted to rerun the failed workflows, but GitHub requires repository admin access. Could you please rerun them when convenient? |
There was a problem hiding this comment.
Pull request overview
Fixes Linux remote process picker failures on systems where ps interprets comma-separated -o formats differently (personality-dependent behavior), by constructing a more portable ps command.
Changes:
- Update Linux
psinvocation to pass each output column with a separate-ooption. - Add a regression test asserting the portable Linux
pscommand string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Extension/src/Debugger/nativeAttach.ts | Updates PsProcessParser.psLinuxCommand to use repeated -o options for portability. |
| Extension/test/scenarios/SingleRootProject/tests/extension.test.ts | Adds a regression test verifying the Linux ps command construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Fixes #14442.
The Linux remote process picker now passes each output column to
pswith a separate-ooption. This avoids the personality-dependent interpretation of comma-separated format specifications while preserving the existing PID, command name, and arguments output layout.A regression test verifies the portable command construction.
Validation
corepack yarn compile(passed)git diff --check(passed)The
SingleRootProjectscenario runner could not execute locally because the native cpptools binaries are not included in the public source checkout. The scenario test containing the new assertion compiled successfully.