Conversation
github-actions
Bot
added
platform: Android
Saadnajmi
reviewed
Jul 1, 2026
Comment on lines
-252
to
+255
| ../scripts/react-native.mts run-ios | ||
| ../scripts/react-native.ts run-ios |
Member
Author
There was a problem hiding this comment.
Because tools like oxfmt use the type field in package.json to determine whether files are ESM and complain if they're not. I've finally set root to be ESM so we don't need to use the .mjs/.mts extension any longer.
Saadnajmi
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set up Knip and fix issues
Platforms affected
Test plan
CI should pass