Skip to content

feat(macos): port RedBox 2.0 to AppKit via RCTUIKit compatibility primitives #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saadnajmi wants to merge 14 commits into
base: saadnajmi/0-85-redbox2-merge
Choose a base branch
from
Open

feat(macos): port RedBox 2.0 to AppKit via RCTUIKit compatibility primitives #3054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8f279b5
feat(macos): add RCTUITableView compatibility primitive to RCTUIKit
Saadnajmi Jul 28, 2026
0758fae
fix(macos): implement RCTUILabel compatibility properties
Saadnajmi Jul 28, 2026
c1e5784
feat(macos): add narrow RCTUIButton action bridge
Saadnajmi Jul 28, 2026
c2ebe70
fix(macos): correct RCTUITableView lifecycle and sizing
Saadnajmi Jul 28, 2026
ca3135f
fix(macos): constrain RCTUITableViewCell content
Saadnajmi Jul 28, 2026
a02d20a
fix(macos): preserve fixed RCTUITableView row heights
Saadnajmi Jul 28, 2026
ac7aa63
fix(macos): update table label wrapping on resize
Saadnajmi Jul 28, 2026
24f6059
fix(macos): preserve RCTUITableView header heights
Saadnajmi Jul 28, 2026
cb3148a
fix(macos): preserve custom RCTUITableViewCell layout
Saadnajmi Jul 28, 2026
994efe8
fix(macos): reuse RCTUITableView header constraints
Saadnajmi Jul 28, 2026
e61b81c
fix(macos): preserve table cell content insets
Saadnajmi Jul 28, 2026
b1c27df
feat(macos): port RedBox 2.0 to AppKit
Saadnajmi Jul 25, 2026
7976bf1
fix(macos): enable RedBox 2 AppKit controller
Saadnajmi Jul 27, 2026
c631f74
refactor(macos): migrate RedBox 2.0 to RCTUIKit primitives
Saadnajmi Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/react-native/React/CoreModules/RCTRedBox.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@

#import "CoreModulesPlugins.h"
#import "RCTRedBox+Internal.h"
#if !TARGET_OS_OSX // [macOS]
#import "RCTRedBox2Controller+Internal.h"
#endif // [macOS]
#import "RCTRedBoxController+Internal.h"

#if RCT_DEV_MENU
Expand Down Expand Up @@ -197,11 +195,9 @@ - (void)showErrorMessage:(NSString *)message
errorInfo = [self _customizeError:errorInfo];

if (self->_controller == nullptr) {
if (!TARGET_OS_OSX && facebook::react::ReactNativeFeatureFlags::redBoxV2IOS()) { // [macOS]
#if !TARGET_OS_OSX // [macOS]
if (facebook::react::ReactNativeFeatureFlags::redBoxV2IOS()) {
self->_controller = [[RCTRedBox2Controller alloc] initWithCustomButtonTitles:self->_customButtonTitles
customButtonHandlers:self->_customButtonHandlers];
#endif // [macOS]
} else {
self->_controller = [[RCTRedBoxController alloc] initWithCustomButtonTitles:self->_customButtonTitles
customButtonHandlers:self->_customButtonHandlers];
Expand Down
13 changes: 7 additions & 6 deletions packages/react-native/React/CoreModules/RCTRedBox2AnsiParser+Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

#import <React/RCTDefines.h>

#if !TARGET_OS_OSX // [macOS]
#import <UIKit/UIKit.h>
#import <React/RCTUIKit.h> // [macOS]

/**
* Parses ANSI escape sequences in text and produces an NSAttributedString
Expand All @@ -18,10 +15,14 @@
*/
@interface RCTRedBox2AnsiParser : NSObject

#if !TARGET_OS_OSX // [macOS]
+ (NSAttributedString *)attributedStringFromAnsiText:(NSString *)text
baseFont:(UIFont *)font
baseColor:(UIColor *)color;
#else // [macOS
+ (NSAttributedString *)attributedStringFromAnsiText:(NSString *)text
baseFont:(UIFont *)font
baseColor:(RCTPlatformColor *)color;
#endif // macOS]

@end

#endif // [macOS]
15 changes: 14 additions & 1 deletion packages/react-native/React/CoreModules/RCTRedBox2AnsiParser.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,32 @@
#import <React/RCTDefines.h>
#import <react/debug/redbox/AnsiParser.h>

#if RCT_DEV_MENU && !TARGET_OS_OSX // [macOS]
#if RCT_DEV_MENU

using facebook::react::unstable_redbox::AnsiColor;
using facebook::react::unstable_redbox::parseAnsi;

#if !TARGET_OS_OSX // [macOS]
static UIColor *RCTUIColorFromAnsiColor(const AnsiColor &c)
{
return [UIColor colorWithRed:c.r / 255.0 green:c.g / 255.0 blue:c.b / 255.0 alpha:1.0];
}
#else // [macOS
static RCTPlatformColor *RCTUIColorFromAnsiColor(const AnsiColor &c)
{
return [RCTPlatformColor colorWithRed:c.r / 255.0 green:c.g / 255.0 blue:c.b / 255.0 alpha:1.0];
}
#endif // macOS]

@implementation RCTRedBox2AnsiParser

#if !TARGET_OS_OSX // [macOS]
+ (NSAttributedString *)attributedStringFromAnsiText:(NSString *)text baseFont:(UIFont *)font baseColor:(UIColor *)color
#else // [macOS
+ (NSAttributedString *)attributedStringFromAnsiText:(NSString *)text
baseFont:(UIFont *)font
baseColor:(RCTPlatformColor *)color
#endif // macOS]
{
if (text == nil) {
return [[NSAttributedString alloc] init];
Expand Down
6 changes: 4 additions & 2 deletions packages/react-native/React/CoreModules/RCTRedBox2Controller+Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,16 @@
*/

#import <React/RCTDefines.h>
#import <React/RCTUIKit.h> // [macOS]

#import "RCTRedBox+Internal.h"

#if RCT_DEV_MENU && !TARGET_OS_OSX // [macOS]
#if RCT_DEV_MENU

typedef void (^RCTRedBox2ButtonPressHandler)(void);

@interface RCTRedBox2Controller : UIViewController <RCTRedBox2Controlling, UITableViewDelegate, UITableViewDataSource>
@interface RCTRedBox2Controller
: RCTPlatformViewController <RCTRedBox2Controlling, RCTUITableViewDelegate, RCTUITableViewDataSource> // [macOS]

@property (nonatomic, weak) id<RCTRedBoxControllerActionDelegate> actionDelegate;

Expand Down
Loading
Loading