[torchlib] Support offset-based grouped_mm layouts - #3017
Open
TANGBUDU wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
Build on the existing converter from microsoft#2805. Unroll a static group count while preserving runtime offsets and logical output shapes. Add numerical, dynamic-input, empty-group, and compatibility tests. Assisted-by: ChatGPT
TANGBUDU
force-pushed
the
fix/grouped-mm-onnx-export-2795
branch
from
September 7, 2026 07:58
fad77e4 to
8e000b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the
aten_grouped_mmconverter added in #2805 and adds support for its offsets form. The existing dense, bias, and cast paths are unchanged.The converter now handles three layouts:
The number of groups must be known at export time, but offset values and input lengths can remain dynamic. If the final offset does not cover the full input, the converter keeps PyTorch's full output shape and fills the unwritten tail with zeros.
The offsets path does not currently support bias or changing the output dtype. The existing dense converter still supports both.
Testing
lintrunner -aandgit diff --checkpass.AI assistance
ChatGPT assisted with the implementation, tests, and result analysis. I reviewed the changes and the test results above.