ci: enable WHP FreeBSD PCAT disk boot test - #158
Merged
Merged
Conversation
Enable multiarch::openvmm_pcat_x64_freebsd_13_2_x64_boot_no_agent in the WHP VMM lane by removing only its anchored exact exclusion. Keep the FreeBSD ISO and both Windows PCAT cases excluded and update regression coverage for the remaining set. Related: #135 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 21, 2026 05:24
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused filter change matches the stated scope and is covered by the updated test and reported WHP validation.
Review effort: Balanced
Findings: None
What changed in this PR
Enables the validated FreeBSD 13.2 PCAT disk-boot test in the WHP VMM lane.
Changes:
- Removes the test’s exact WHP exclusion while preserving the other three exclusions.
- Updates coverage to document the enabled test and exclusion count.
| File | Description |
|---|---|
scripts/nvx_tools/ci.py |
Enables the FreeBSD PCAT disk-boot test for WHP. |
scripts/test_nvx_tools.py |
Verifies the test is no longer excluded. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
deleted the
enable-whp-freebsd-pcat-disk
branch
September 21, 2026 13:02
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiarch::openvmm_pcat_x64_freebsd_13_2_x64_boot_no_agentin the WHP VMM laneNo OpenVMM pin change is required.
Validation
Related: #135