Skip to content

[code-improvement] reusability: reuse shared SHA-256 helper #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pedro Henrique Penna (ppenna) merged 1 commit into from
Sep 21, 2026
+7 −14
Merged

[code-improvement] reusability: reuse shared SHA-256 helper #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions scripts/nvx_tools/benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import ctypes
import datetime as dt
import errno
import hashlib
import io
import ipaddress
import json
Expand All @@ -33,6 +32,8 @@
from string import Template
from typing import TextIO, TypedDict, cast

from .common import sha256_file

BOOT_MARKER = b"ALPINE-MICROVM-BOOT-OK"
RESTORE_MARKER = b"OPENVMM-SNAPSHOT-RESTORE-OK"
TEARDOWN_TIMEOUT_SECONDS = 15.0
Expand Down Expand Up @@ -3734,14 +3735,6 @@ def _git_status(repository: Path) -> list[str] | None:
return None


def _sha256_file(path: Path) -> str:
digest = hashlib.sha256()
with path.open("rb") as source:
while chunk := source.read(1024 * 1024):
digest.update(chunk)
return digest.hexdigest()


def _device_io_helper_provenance(
args: argparse.Namespace, initrd: Path
) -> dict[str, str]:
Expand All @@ -3762,7 +3755,7 @@ def _device_io_helper_provenance(
raise ValueError(
f"invalid nvx-device-io provenance in {manifest_path}"
) from error
actual_source_sha256 = _sha256_file(source)
actual_source_sha256 = sha256_file(source)
if source_sha256 != actual_source_sha256:
raise ValueError(
"initramfs device I/O helper source does not match the current checkout"
Expand Down Expand Up @@ -3852,10 +3845,10 @@ def write_benchmark_metadata(
}
if device_io:
document["artifact_sha256"] = {
"openvmm": _sha256_file(executable),
"kernel": _sha256_file(kernel),
"initrd": _sha256_file(initrd),
"benchmark_coordinator": _sha256_file(Path(__file__)),
"openvmm": sha256_file(executable),
"kernel": sha256_file(kernel),
"initrd": sha256_file(initrd),
"benchmark_coordinator": sha256_file(Path(__file__)),
}
document["device_io_helper"] = _device_io_helper_provenance(args, initrd)
path = output_dir / BENCHMARK_METADATA_FILENAME
Expand Down
Loading