ci: enable KVM legacy xAPIC VMM test - #152
Merged
Merged
Conversation
Enable x86_64_exclusive::openvmm_linux_x64_legacy_xapic and advance OpenVMM to the exact head of nanvix/openvmm#87. Represent the remaining issue #135 KVM exclusions as anchored, fully qualified nextest selectors so removing the legacy xAPIC entry enables exactly one test without broadening PCAT or APIC-offset coverage. The OpenVMM fix maps logical VP metadata to APIC-based KVM VCPU IDs for BSP and TSC-frequency paths, allowing sparse legacy xAPIC topologies to launch. Related: #135 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 21, 2026 00:14
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The hardware-dependent change pins an open, currently blocked OpenVMM pull request and needs final human validation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Enables the legacy xAPIC OpenVMM test in KVM CI alongside the required OpenVMM revision.
Changes:
- Uses anchored selectors for remaining KVM exclusions.
- Removes the legacy xAPIC exclusion.
- Updates filter configuration tests.
| File | Description |
|---|---|
| scripts/test_nvx_tools.py | Verifies KVM exclusion configuration. |
| scripts/nvx_tools/ci.py | Defines exact KVM test exclusions and enables legacy xAPIC. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Check for the legacy xAPIC leaf name anywhere in the KVM filter so both anchored and historical substring exclusions fail the regression test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 21, 2026 01:08
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
c17e2d36365fc495a0ecbc57b1a93c2e7c91ba4f)x86_64_exclusive::openvmm_linux_x64_legacy_xapicin the KVM laneDependency
This PR depends on nanvix/openvmm#87. That change addresses KVM VCPU handles by APIC ID instead of mixing the KVM key space with logical VP indices.
openvmm_linux_x64_apicid_offsetand the five Linux PCAT cases remain excluded by exact name.Validation
OpenVMM source PR
virt_kvmnextest: 25 passed, 2 hardware-dependent tests skippedNVX integration
Related: #135