[code-improvement] code-quality: handle invalid UTF-8 sandbox state - #151
Merged
Pedro Henrique Penna (ppenna) merged 1 commit intoSep 21, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 20, 2026 23:47
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused error handling is correct and covered by an appropriate regression test.
Review effort: Balanced
Findings: None
What changed in this PR
Normalizes invalid UTF-8 sandbox state errors into actionable ScriptError diagnostics.
Changes:
- Catch
UnicodeDecodeErrorin the shared JSON reader. - Add focused regression coverage.
| File | Description |
|---|---|
| scripts/test_nvx_tools.py | Tests invalid UTF-8 handling. |
| scripts/nvx_tools/sandbox_lifecycle.py | Converts decoding failures to ScriptError. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
marked this pull request as ready for review
September 20, 2026 23:49
Pedro Henrique Penna (ppenna)
deleted the
code-improvement/sandbox-json-utf8-810d161569205c5d
branch
September 21, 2026 00:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Category:
code-qualitySandbox lifecycle JSON readers promise actionable
ScriptErrorfailures for unreadable or malformed state. Invalid UTF-8 currently escapes that boundary as a rawUnicodeDecodeError, producing an internal traceback instead of the existingfailed to read ...diagnostic.Evidence and novelty
dev(c7630757b716ea7f3b5e5e3be63b3ddc4b736689):_read_json()raisedUnicodeDecodeErrorfor a one-byte invalid UTF-8 file.code-qualitycategory rather than a stale CI-failure fix.UnicodeDecodeError, sandbox lifecycle JSON, andScriptError; no matching active work exists.Change
scripts/nvx_tools/sandbox_lifecycle.py: normalize invalid UTF-8 decoding failures to the existing actionableScriptErrorpath.scripts/test_nvx_tools.py: add focused regression coverage for invalid UTF-8 sandbox configuration.Patch size: 2 files, 9 additions + 1 deletion = 10 changed lines.
Validation
All commands passed:
python -m unittest scripts.test_nvx_tools.SandboxTests.test_versioned_json_reader_rejects_invalid_utf8 -vpython3 -m compileall -q scriptspython3 -m unittest scripts/test_performance.py scripts/test_nvx_tools.py scripts/test_microvm_tests.py scripts/test_development_release.py -vpython3 .github/skills/nvx-host-connect/scripts/test_hosts.py -vpython3 scripts/nvx.py --helppython3 scripts/nvx.py test-openvmm-unit --helppython3 scripts/nvx.py test-openvmm --helppython3 scripts/nvx.py test-microvm --helppython3 scripts/nvx.py benchmark --helppython3 -m ruff check scriptspython3 -m pyright --pythonplatform Linuxpython3 -m pyright --pythonplatform Windowspython3 -m ruff format --check scriptsgit diff --checkNo dependency, public API/CLI/ABI, gitlink, or OpenVMM change was made.