Fix msquic performance tests - #869
Open
Alan-Jowett wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
.github/scripts/run-quic-echo-test.ps1script and thenetwork-traffic-performance.ymlworkflow to add support for a newmsquicpriv.syskernel driver, ensure it is properly installed and loaded both locally and remotely, and to update the workflow to track which environments support themsquic-kmbackend. The changes also update the referenced commit for theWinQuicEchotool.Kernel driver management improvements:
Get-MsQuicPrivDriverPathandEnsure-MsQuicPrivLoadedfunctions to locate and load the newmsquicpriv.syskernel driver. The script now ensures bothmsquic.sysandmsquicpriv.sysare installed and running before loading theWinQuicEchokernel-mode driver, both locally and remotely. [1] [2] [3]Install-LocalWinQuicEchoKmDriver,Install-RemoteWinQuicEchoKmDriver,Prepare-WinQuicEchoKmDriver) to require and handle the additionalmsquicpriv.sysdriver. These functions now pass and validate the new driver path, copy it to the target, and set up service dependencies accordingly. [1] [2] [3] [4] [5] [6] [7]Service dependency changes:
WinQuicEchokernel service dependency frommsquictomsquicpriv, ensuring the service only starts aftermsquicprivis loaded. This affects both service creation and configuration, locally and remotely. [1] [2] [3] [4]Workflow and environment updates:
network-traffic-performance.ymlworkflow to reference a new commit of theWinQuicEchotool and to include asupports_msquic_kmflag in the test matrix, indicating which environments support the kernel-mode backend. [1] [2]These changes ensure that the new
msquicpriv.sysdriver is always present and active when running kernel-mode echo tests, improving reliability and compatibility for environments that support this backend.