Skip to content

Migrate Windows file clients to the broker - #1363

Open
Weidong Cui (wdcui) wants to merge 1 commit into
wdcui/ulitebox/broker-files-09-windows-facadefrom
wdcui/ulitebox/broker-files-10-windows-clients
Open

Migrate Windows file clients to the broker#1363
Weidong Cui (wdcui) wants to merge 1 commit into
wdcui/ulitebox/broker-files-09-windows-facadefrom
wdcui/ulitebox/broker-files-10-windows-clients

Conversation

@wdcui

Copy link
Copy Markdown
Member

This PR routes Windows file, PE loader, NLS, section, and runner operations through broker-backed LiteBox APIs and atomically moves registry keys and typed values into the isolated /registry namespace, with shared in-process broker coverage for the migrated behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 239ec5f7-870a-4259-bcae-4ca85fb913a0
@wdcui
Weidong Cui (wdcui) force-pushed the wdcui/ulitebox/broker-files-09-windows-facade branch from 4b68be6 to 87766e8 Compare September 13, 2026 00:54
@wdcui
Weidong Cui (wdcui) force-pushed the wdcui/ulitebox/broker-files-10-windows-clients branch from e7bd400 to aa180f9 Compare September 13, 2026 00:54
@github-actions

Copy link
Copy Markdown

ℹ️ Note: This semver check was run against the wdcui/ulitebox/broker-files-09-windows-facade branch, not main or ulitebox.

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field ---

Description:
A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field CliArgs.broker_control_channel in /home/runner/work/litebox/litebox/litebox_runner_windows_on_linux_userland/src/lib.rs:45

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron

Failed in:
  WindowsShimBuilder::new, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-wdcui_ulitebox_broker_files_09_windows_facade/25d61a9739fcb00496d2c67f0c2ce278dc0d2c85/litebox_shim_windows/src/lib.rs:409
  WindowsShimBuilder::default_fs, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-wdcui_ulitebox_broker_files_09_windows_facade/25d61a9739fcb00496d2c67f0c2ce278dc0d2c85/litebox_shim_windows/src/lib.rs:426

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/method_parameter_count_changed.ron

Failed in:
  litebox_shim_windows::WindowsShim::load_program takes 4 parameters in /home/runner/work/litebox/litebox/target/semver-checks/git-wdcui_ulitebox_broker_files_09_windows_facade/25d61a9739fcb00496d2c67f0c2ce278dc0d2c85/litebox_shim_windows/src/lib.rs:510, but now takes 3 parameters in /home/runner/work/litebox/litebox/litebox_shim_windows/src/lib.rs:492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant