Skip to content

[AI Generated] BugFix: add SecureBoot to TrustedLaunchAndConfidentialVmSupported Linux image capabilities - #4682

Open
Johnson (johnsongeorge-w) wants to merge 1 commit into
mainfrom
feature/tl_fix
Open

[AI Generated] BugFix: add SecureBoot to TrustedLaunchAndConfidentialVmSupported Linux image capabilities#4682
Johnson (johnsongeorge-w) wants to merge 1 commit into
mainfrom
feature/tl_fix

Conversation

@johnsongeorge-w

@johnsongeorge-w Johnson (johnsongeorge-w) commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Linux images with SecurityType=TrustedLaunchAndConfidentialVmSupported were missing SecureBoot from their parsed security profile capabilities. This caused test cases requiring security_profile: secureboot to be skipped with:

capability doesn't support requirement: security_profile: requires [secureboot] but VM supports [cvm, stateless]

The Windows code path correctly included SecureBoot for the same SecurityType, but the Linux/generic path only set [CVM, Stateless]. This fix adds SecurityProfileType.SecureBoot to align with the Windows behavior and Azure documentation.

Validation Results

Image Result
almalinux almalinux-x86_64 9-gen2 latest PASSED
canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest PASSED

Copilot AI lite review requested due to automatic review settings August 19, 2026 14:57
@johnsongeorge-w Johnson (johnsongeorge-w) changed the title BugFix: add SecureBoot to TrustedLaunchAndConfidentialVmSupported Linux image capabilities [AI Generated] BugFix: add SecureBoot to TrustedLaunchAndConfidentialVmSupported Linux image capabilities Aug 19, 2026
Copilot AI reviewed Aug 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Azure Linux image capability parsing so images advertising SecurityType=TrustedLaunchAndConfidentialVmSupported include SecureBoot in their security_profile capability set, preventing Secure Boot–requiring test cases from being incorrectly skipped.

Changes:

  • Add SecurityProfileType.SecureBoot to the Linux/generic parsing path for confidential/trusted-launch capable images in _parse_security_profile.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lisa/sut_orchestrator/azure/common.py Outdated
Copilot AI review requested due to automatic review settings August 19, 2026 15:00
@LiliDeng

LiliDeng commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

AI Test Case Selection

Selected 1 test case(s): smoke_test

Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest

Result: Succeeded

View full logs in Azure DevOps

Copilot AI reviewed Aug 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@LiliDeng

LiliDeng commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Kameron Carr (@kamalca) I recalled that you ever have done some changes here, could you please review the code? Thanks.

kamalca
Kameron Carr (kamalca) requested changes Aug 20, 2026
View reviewed changes

@kamalca Kameron Carr (kamalca) left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux CVM images intentionally leave out SecureBoot because CVM Linux images are intended to be used in CVM scenarios only.

If you make this change, testing a CVM image will likely land on GP SKUs during automated testing instead of on CVM SKUs.

For Windows images there is only a single option that supports both GP and CVM scenarios. For Linux there is one image for GP scenarios and a separate image for CVM scenarios. This is the reason for treating them differently.

kamalca
Kameron Carr (kamalca) reviewed Aug 20, 2026
View reviewed changes
Comment thread lisa/sut_orchestrator/azure/common.py
Copilot AI review requested due to automatic review settings August 26, 2026 02:22
Copilot AI reviewed Aug 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread lisa/sut_orchestrator/azure/common.py
@LiliDeng

LiliDeng commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

AI Test Case Selection

Selected 1 test case(s): smoke_test

Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest

Result: Succeeded

View full logs in Azure DevOps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@LiliDeng LiliDeng Awaiting requested review from LiliDeng LiliDeng is a code owner
@kamalca Kameron Carr (kamalca) Awaiting requested review from kamalca

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

🛑 DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnsongeorge-w @LiliDeng @kamalca