fix: preserve child routing and restore nested resume credentials - #340
Merged
Merged
Conversation
Canonicalize effective caller preferences before child mounts, retain caller provenance across cold resumes, and restore only redacted nested secret leaves from matching live settings. Consume Foundation resolution diagnostics when available so fallback reporting is singular and truthful. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Prove a no-parent cold resume preserves a persisted concrete Anthropic Sonnet model when its caller preference is a matching glob, with no fallback event or unresolved-preference warning. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Add safe preference warnings and honest legacy diagnostics, match secret refreshes by stable identity, and cover the cold-resume regression. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Preserves child routing and restores nested resume credentials across the full resume chain:
The lockfile also pins released
amplifier-core1.6.1 and mergedamplifier-foundationcommite210edabd947af82d5121a240d6934283ac540b9.Dependency
Foundation PR #386 is merged as
e210edabd947af82d5121a240d6934283ac540b9:microsoft/amplifier-foundation#386
The core patch is explicitly excluded; this branch targets PyPI
amplifier-core1.6.1.Evidence
2279passed,4skipped,13deselected,1xfailed.13passed.Scope notes
Existing PRs #232 and #233 may overlap. This PR does not claim to supersede either one; neither is being closed.
Breaking changes
None expected.