Fix Build - #1293
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores compilation on main after merge-order conflicts between PRs that refactored the Neighbor API and introduced the diskann-inmem provider, by updating call sites to the new accessor-based Neighbor interface and ensuring CI also builds the diskann-inmem integration-test configuration.
Changes:
- Update
diskann-inmemprovider code to useNeighbor::id()/Neighbor::distance()accessors. - Update
diskann-inmemintegration index tests to useNeighbor::id()accessor. - Extend CI and nightly feature matrices to include the
diskann-inmemintegration-testfeature so it is compiled in automation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
diskann-inmem/src/provider.rs |
Fixes compilation against the updated Neighbor API during search post-processing. |
diskann-inmem/integration/index/tests.rs |
Fixes integration index test compilation against the updated Neighbor API. |
.github/workflows/nightly.yml |
Ensures nightly “all features” builds also compile the diskann-inmem integration-test configuration. |
.github/workflows/ci.yml |
Ensures PR CI feature builds also compile the diskann-inmem integration-test configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 91.49% 90.62% -0.88%
==========================================
Files 497 512 +15
Lines 95548 98807 +3259
==========================================
+ Hits 87423 89539 +2116
- Misses 8125 9268 +1143
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Merge order woes between #1273 and #1206 resulted in
mainbeing broken. This fixes compilation.