Skip to content

Docker image build pipeline fixes #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patrick Nelson (plnelson) merged 3 commits into from
Aug 26, 2026
+11 −4
Merged

Docker image build pipeline fixes #607

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a68403
Configure Windows SDL analysis pool
plnelson Aug 25, 2026
129f7b0
Use ARM connection for ACR authentication
plnelson Aug 26, 2026
0642c84
Potential fix for pull request finding
plnelson Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions build/yaml/pipelines/build_images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ parameters:
displayName: Container image tag
type: string
default: latest
- name: RegistryServiceConnection
displayName: ACR Docker service connection
- name: RegistryArmServiceConnection
displayName: ACR Azure Resource Manager service connection
type: string
default: 'VS Diagnostics Dev (ProdDiagBuild)'

Expand All @@ -42,6 +42,11 @@ extends:
image: 1ESPT-Ubuntu20.04
os: linux

sdl:
sourceAnalysisPool:
name: VSEngSS-MicroBuild2022-1ES
os: windows
Comment thread
plnelson marked this conversation as resolved.

stages:
- stage: BuildImages
displayName: Build Linux images
Expand All @@ -52,7 +57,8 @@ extends:

templateContext:
authenticatedContainerRegistries:
- serviceConnection: ${{ parameters.RegistryServiceConnection }}
- armServiceConnection: ${{ parameters.RegistryArmServiceConnection }}
acrName: proddiagbuild

outputs:
- output: containerImage
Expand All @@ -78,7 +84,8 @@ extends:

templateContext:
authenticatedContainerRegistries:
- serviceConnection: ${{ parameters.RegistryServiceConnection }}
- armServiceConnection: ${{ parameters.RegistryArmServiceConnection }}
acrName: proddiagbuild

outputs:
- output: containerImage
Expand Down
Loading