Skip to content

Fixup matching_partial comment#8011

Merged
achamayou merged 5 commits into
microsoft:mainfrom
cjen1-msft:partial-update-clean
Jul 2, 2026
Merged

Fixup matching_partial comment#8011
achamayou merged 5 commits into
microsoft:mainfrom
cjen1-msft:partial-update-clean

Conversation

@cjen1-msft

Copy link
Copy Markdown
Contributor

Tidy matching_partial scenario

Copilot AI review requested due to automatic review settings July 1, 2026 10:08
@cjen1-msft cjen1-msft requested a review from a team as a code owner July 1, 2026 10:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Tidy-up of the matching_partial Raft scenario description to better explain the intent of the partially-matching AppendEntries reproduction.

Changes:

  • Expanded the header comment to explain the scenario’s goal more explicitly.
  • Adjusted the inline comment near the “matching partial” step to reflect updated trace-validation expectations.
  • Removed a trailing state_all command from the scenario steps.

Custom instructions used:

  • .github/copilot-instructions.md
  • .github/instructions/reviewing.instructions.md

Comment thread tests/raft_scenarios/matching_partial
Comment thread tests/raft_scenarios/matching_partial
@achamayou achamayou enabled auto-merge (squash) July 2, 2026 09:34
@achamayou achamayou merged commit ce0146e into microsoft:main Jul 2, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants