[Expense Agent] Fix administrative recall history access

[Prangshuman Das (t-prda)]

Summary

• authorize pending expense report recall only for the captured submitter or a user with Unlimited Expense Approval
• record non-submitter recalls as BC User activity with the Administrator role
• keep administrative activity outside submitter and approver history participation
• cover genuine submitter, mapped and unmapped administrator, and unauthorized recall scenarios

Validation

• Expense Agent activity log tests passed after manual publication

Fixes AB#647041

[Prangshuman Das (t-prda)]

Agentic PR Review - Round 2

Recommendation: Accept

What this PR does

The new commits improve localization and add explicit coverage for submitters who do and do not have Unlimited Expense Approval. The final code keeps submitter identity ahead of administrator capability and preserves the original authorization and actor-attribution fix.

Status of previous suggestions

ID	Title	Status	Author response
S1	Keep administrator out of history filters	Disputed	The role filter is already combined with the scoped Expense User identity. Administrator events use a BC User actor, so this filter safely returns no matches.

New observations (commits since round 1)

None.

Risk assessment and necessity

Risk: The change remains limited to pending-report recall authorization and activity attribution. Authorization runs before mutation, administrative events cannot grant Expense User history participation, and the added tests cover mixed submitter and administrator capabilities.

Necessity: The fix prevents administrative recall from being blocked or incorrectly recorded as a submitter action. The current scope and regression coverage are appropriate.

---

[AI-PR-REVIEW] version=1 promptVersion=1 system=github pr=10382 round=2 by=t-prda at=2026-08-19T14:10:18.5573284Z lastSha=a49e7870000f17f02d1194a5768f0d558e9c2c26 reviewKey=9e40eb965e48f9be373a4d9fff0456c0ffeafa8f2f332d0566c76852970adf04 suggestions=S1@0dbcbc18:disputed parentRound=1

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Data\ Modeling}$

GetRecallActorRole() authorizes the original submitter by comparing ExpenseReportHeader."Submitter Expense User ID" (a Code[50] snapshot of the BC user name taken at Submit time) with UserId(). If the BC user is later renamed, the stored snapshot no longer matches UserId(), so the original submitter can no longer recall their own report as "Submitter" and falls through to the "Unlimited Expense Approval" administrator check (or is denied outright). This mirrors an existing pattern elsewhere in the codeunit, but it is exercised directly by this new authorization gate, so a user rename between submission and recall silently changes who is allowed to self-recall a report. Consider keying the comparison off an immutable identifier (e.g. the BC User's SystemId/User Security ID) captured at submission time instead of the mutable user name.

_{Agent judgement — not directly backed by a BCQuality knowledge article.}

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.34.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Testing}$

SetCurrentUserUnlimitedExpenseApproval hand-rolls a "User Setup" fixture with Init/Insert instead of using the existing test-library helpers. The Expense Agent test app already depends on Tests-TestLibraries, which ships codeunit 131352 "Library - Document Approvals" with CreateOrFindUserSetup(var UserSetup; UserName), and LibraryExpense.Codeunit.al (in this same test project) already has SetUnlimitedExpenseApprovalLimits/SetLimitedExpenseApprovalLimits(var UserSetup). Hand-rolling Init/Insert bypasses that library-owned setup and will silently break if the User Setup table gains a new mandatory field.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

    local procedure SetCurrentUserUnlimitedExpenseApproval(UnlimitedExpenseApproval: Boolean)
    var
        UserSetup: Record "User Setup";
        LibraryDocumentApprovals: Codeunit "Library - Document Approvals";
    begin
        LibraryDocumentApprovals.CreateOrFindUserSetup(UserSetup, UserId());

        if UnlimitedExpenseApproval then
            LibraryExpense.SetUnlimitedExpenseApprovalLimits(UserSetup)
        else
            LibraryExpense.SetLimitedExpenseApprovalLimits(UserSetup);
    end;

Knowledge:

• microsoft/knowledge/testing/use-library-codeunits-for-test-fixtures.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.34.4}

[alexei-dobriansky]

Agentic PR Review - Round 1

Recommendation: Accept

What this PR does

This PR tightens recall of pending expense reports. A pending report can now be recalled by the captured submitter, or by a user with Unlimited Expense Approval. Administrative recalls are logged as BC User activity with the new Administrator actor role.

The change checks the actor before changing the report status, so an unauthorized recall errors before status or history is updated. The submitter path still logs the captured submitter, while the administrator path uses the BC User record and does not satisfy submitter or approver history filters. The added tests cover submitter precedence, mapped and unmapped administrators, and unauthorized recall.

Suggestions

None.

Risk assessment and necessity

Risk: The touched area affects expense approval history and access to activity records. The codeunit and enum are internal, and the behavior change is limited to pending-report recall. App build checks were successful at review time; the GitHub unit-test matrix was still running.

Necessity: The linked bug is valid because a non-submitter recall could grant incorrect submitter history access. The scope is right: it changes recall authorization and history attribution without changing posting or approval amount logic.

---

[AI-PR-REVIEW] version=1 promptVersion=2 system=github pr=10382 round=1 by=alexei-dobriansky at=2026-08-19T19:14:23Z lastSha=c5f317f0273ae3c5f2bca1340654bb69b77d5f78 reviewKey=4f910e678871fdfa1c2376774cf5438c2d11bd4a784195c2bca3a924466e201a suggestions=none