Skip to content

Remove Anthropic privacy notice from Expense Agent - #10341

Open
encimita wants to merge 9 commits into
mainfrom
encimita-remove-anthropic-expense-agent
Open

Remove Anthropic privacy notice from Expense Agent#10341
encimita wants to merge 9 commits into
mainfrom
encimita-remove-anthropic-expense-agent

Conversation

@encimita

@encimita encimita commented Aug 18, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes AB#646070

Summary

  • Remove Anthropic registration, approval checks, capability requirements, and active privacy notice UI from Expense Agent.
  • Keep the original page 7078 implementation unchanged, mark it pending obsolete, and wrap it in #if not CLEAN29.
  • Attempt to remove the persisted legacy privacy notice and its approval records during the per-database upgrade without blocking the upgrade.
  • Keep the legacy notice ID only as migration data so existing records can be deleted.

Testing

  • No tests added or changed; no Expense Agent tests reference Anthropic.
  • Local AL compilation could not run because NAV initialization requires registry permissions unavailable in this worktree session.

@encimita
Remove Anthropic privacy notice from Expense Agent
cf2543b 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@encimita
Obsolete Anthropic privacy notice page
731783a 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@encimita
Make privacy notice cleanup non-blocking
71a1c61 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Integration GitHub request for Integration area labels Aug 18, 2026
@encimita
Preserve obsolete privacy notice page
dcb42ff 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@encimita
Restore System.Environment import
919d596 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@encimita
Use database upgrade tag for privacy cleanup
74168a6 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@encimita
Add work item to privacy cleanup tag
4025b3a 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@encimita
Remove legacy privacy notice approvals
3d49b12 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@encimita
Tidy privacy cleanup upgrade code
0cd4133 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f556efb0-534d-48fa-8818-be0d8ca8579d
@encimita
encimita marked this pull request as ready for review August 18, 2026 09:40
@encimita
encimita requested a review from a team August 18, 2026 09:40
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 18, 2026
t-prda
Prangshuman Das (t-prda) reviewed Aug 18, 2026
View reviewed changes
Comment thread src/Apps/W1/ExpenseAgent/app/src/Setup/Codeunits/ExpPrivacyNoticeReg.Codeunit.al
begin
exit(AnthropicProductNameTok);
end;
#endif

@t-prda Prangshuman Das (t-prda) Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: after the clean up, there will be 2 new lines instead of 1.

@encimita encimita Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix if another iteration is needed

@encimita encimita removed the Integration GitHub request for Integration area label Aug 18, 2026
@github-actions github-actions Bot added the Integration GitHub request for Integration area label Aug 18, 2026
@onbuyuka Onat Buyukakkus (onbuyuka) added Ownership: Manual Preserve the manually selected team ownership and removed Integration GitHub request for Integration area labels Aug 18, 2026
@github-actions github-actions Bot added the Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction label Aug 18, 2026
@onbuyuka Onat Buyukakkus (onbuyuka) added the Other GitHub request for other area than SCM, Finance or Integration label Aug 18, 2026
@github-actions github-actions Bot removed the Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction label Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@BardurKnudsen Bardur Knudsen (BardurKnudsen) BardurKnudsen approved these changes
@onbuyuka Onat Buyukakkus (onbuyuka) onbuyuka approved these changes
@t-prda Prangshuman Das (t-prda) t-prda approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

AL: Apps (W1) Add-on apps for W1 Other GitHub request for other area than SCM, Finance or Integration Ownership: Manual Preserve the manually selected team ownership

Projects

None yet

Milestone

Version 29.0

Development

Successfully merging this pull request may close these issues.

4 participants

@encimita @BardurKnudsen @onbuyuka @t-prda