Unblock bc login due to pp failures

[rupeshdan]

Fixes AB#620236

What & why

Prevents Business Central sign-in from being blocked when the linked Power Platform environment lookup fails.

The change:

• Handles lookup failures without surfacing them to the caller and logs telemetry for diagnosis.
• Ignores null GUID and empty environment responses.
• Returns a clear error when no Power Platform tenant is configured.
• Adds integration tests for failed, null, valid, and empty-response scenarios.

Tests and the outcome

Added integration coverage confirming that:

• Linked-environment lookup failures do not surface or return an environment ID.
• Null GUIDs are not returned.
• Valid linked environment IDs are returned.
• Empty environment responses produce an empty environment buffer.

Risk & compatibility

Low risk. The change preserves successful environment lookup behavior while preventing Power Platform failures from blocking Business Central sign-in. No data upgrade or breaking API changes are introduced.

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Events}$

The new OnBeforeGetLinkedPowerPlatformEnvironmentId hook passes a var Handled flag without resetting it to false immediately before the raise. Add Handled := false; on the line before OnBeforeGetLinkedPowerPlatformEnvironmentId(...) so the override path stays deterministic and self-documenting, consistent with the existing handled-event pattern elsewhere in this codeunit.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

            // if not, use the linked environment if exists
            Handled := false;
            OnBeforeGetLinkedPowerPlatformEnvironmentId(LinkedEnvironmentId, Handled);
            if not Handled then
                LinkedEnvironmentId := EnvironmentInformation.GetLinkedPowerPlatformEnvironmentId();

Knowledge:

• microsoft/knowledge/events/initialize-ishandled-to-false-before-publishing.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.33.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance}$

GetEnvironments requests an Azure AD access token before it checks whether GetFlowEnvironmentsApi() returned a tenant URL. When the Business Central environment is not linked to a Power Platform tenant, every invocation pays the token-acquisition cost and then errors immediately. Resolve FlowEnvironmentsUrl first and raise PowerPlatformTenantNotConfiguredErr before requesting the access token.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

            // Gets a list of Flow user environments from the Flow API.
            FlowEnvironmentsUrl := GetFlowEnvironmentsApi();
            if FlowEnvironmentsUrl = '' then
                Error(PowerPlatformTenantNotConfiguredErr);

            AccessToken := AzureAdMgt.GetAccessTokenAsSecretText(FlowARMResourceUrlTxt, FlowResourceNameTxt, false);

            if AccessToken.IsEmpty() then
                Session.LogMessage('0000MJX', EmptyAccessTokenTelemetryMsg, Verbosity::Error, DataClassification::SystemMetadata, TelemetryScope::ExtensionPublisher, 'Category', PowerAutomatePickerTelemetryCategoryLbl);

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.33.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Privacy}$

The new Session.LogMessage call builds its telemetry message with StrSubstNo(LinkedEnvironmentLookupFailedMsg, Scenario, LastErrorCode). Privacy/telemetry guidance expects the message text to stay static, non-personal, and bounded, with structured context moved into custom dimensions instead of being baked into the free-text message. Embedding the caller-supplied Scenario and the raw GetLastErrorCode() value directly in the message makes the payload unbounded and harder to prove non-personal, so DataClassification::SystemMetadata may not match what actually ships. Keep the message constant and move Scenario/error-code into custom dimensions with a documented, bounded schema.

Knowledge:

• microsoft/knowledge/privacy/no-pii-in-telemetry-message-string.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.33.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Testing}$

The new test suite covers linked-environment lookup failures and an empty HTTP response, but it does not exercise the new GetEnvironments() branch where GetFlowEnvironmentsApi() returns an empty string and raises PowerPlatformTenantNotConfiguredErr. Add a negative test that forces the tenant URL lookup to be empty and asserts that specific error so this new failure mode cannot regress unnoticed.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.33.4}