Skip to content

[Master] - Slice 640778: [Sustainability] Sustainability Entries should be more easy to find like other entries across BC - #10311

Open
v-rohangarg20 wants to merge 1 commit into
mainfrom
feature/640778-sustainability-entries-find-entries-and-item-history
Open

[Master] - Slice 640778: [Sustainability] Sustainability Entries should be more easy to find like other entries across BC#10311
v-rohangarg20 wants to merge 1 commit into
mainfrom
feature/640778-sustainability-entries-find-entries-and-item-history

Conversation

@v-rohangarg20

@v-rohangarg20 v-rohangarg20 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

AB#640778

  1. Find Entries on Sustainability Ledger Entries page

Added Find entries... (Navigate) action with Ctrl+Alt+Q shortcut to the Sustainability Ledger Entries page, matching the pattern already used on the Sustainability Value Entries page.

  1. Sustainability Value Entries on Item Card and Item List

Added Sustainability Value Entries action to the Item Card's Related → History → Entries section (after Warehouse Entries), filtered by "Item No.".
Added the same action to the Item List page.
Both actions are only visible when Item Emissions is enabled in Sustainability Setup.

…st. Value Entries to Item Card/List history (Slice 640778)
@v-rohangarg20
v-rohangarg20 requested a review from a team August 17, 2026 13:46
@v-rohangarg20
v-rohangarg20 requested a review from a team as a code owner August 17, 2026 13:46
@v-rohangarg20 v-rohangarg20 added the Finance GitHub request for Finance area label Aug 17, 2026
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Aug 17, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 17, 2026
@v-rohangarg20 v-rohangarg20 reopened this Aug 17, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Agentic PR Review - Round 1

Recommendation: Accept with Suggestions

What this PR does

This Slice adds easier entry discovery for Sustainability: a Find entries action on Sustainability Ledger Entries, plus Sustainability Value Entries actions on Item Card and Item List. The Navigate action follows the existing Sustainability Value Entries pattern and uses the selected posting date and document number, so the main behavior looks correct. The item actions use the correct page link for Type = Item and item number, but their visibility is less clearly aligned with the existing value-entry setup model.

Suggestions

S1 - Use value-chain visibility for value entries
The new item actions are visible when only Item Emissions is enabled. Sustainability Value Entries are generated by value chain tracking, and existing Value Entries actions use that setup flag. Use the value chain tracking flag for these actions, or explain why item-only visibility is intended.

S2 - Cover the ledger Find entries action
The tests cover the Item Card and Item List actions, but not the new Find entries action on Sustainability Ledger Entries. Add a page test or handler that invokes the action and checks that it opens Navigate for the selected document.

Risk assessment and necessity

Risk: The change is mostly UI navigation and does not change posting, amounts, ledger creation, public APIs, or event publishers. The main regression risk is showing a Sustainability Value Entries action when value chain tracking is off, which can send users to an empty or misleading list. No BaseApp event publisher verification was needed.

Necessity: The Slice is valid and the scope is small. The added actions make existing Sustainability entries easier to find from the ledger and item pages, which matches the PR description and analogous entry-navigation patterns.


[AI-PR-REVIEW] version=1 promptVersion=2 system=github pr=10311 round=1 by=alexei-dobriansky at=2026-08-17T19:10:00Z lastSha=a2aafae51bf5aa39365e8acabe8f07f6c435f017 reviewKey=05daac175c1da2a2561733307d3158283583c3f64f43f37310db62d1c91c6db9 suggestions=S1@4343dbe5,S2@9ac6629b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants