Truncate Shopify PO Number to External Document No. length - #10305
Open
Sean Schade (seanschade) wants to merge 1 commit into
Open
Truncate Shopify PO Number to External Document No. length#10305Sean Schade (seanschade) wants to merge 1 commit into
Sean Schade (seanschade) wants to merge 1 commit into
Conversation
…ocessOrder The PO number coming from Shopify can exceed 35 characters, while Sales Header "External Document No." is Code[35]. The direct Validate call made order creation fail with a string-length error for any B2B order with a long PO number. Truncate with CopyStr/MaxStrLen like the other string mappings in this procedure. Fixes microsoft#10243
github-actions
Bot
added
AL: Apps (W1)
Contributor
|
Issue #10243 is not valid. Please make sure you link an issue that exists, is open and is approved. |
github-actions
Bot
added
Integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncate Shopify PO Number to External Document No. length in ShpfyProcessOrder
The PO number coming from Shopify can exceed 35 characters, while Sales Header "External Document No." is Code[35]. The direct Validate call made order creation fail with a string-length error for any B2B order with a long PO number. Truncate with CopyStr/MaxStrLen like the other string mappings in this procedure.
Fixes #10243
What & why
Linked work
Fixes #
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility