Skip to content

requests: Add context manager for response object. #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gadgetoid wants to merge 1 commit into from
Closed

requests: Add context manager for response object. #1121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python-ecosys/requests/requests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ def json(self):

return json.loads(self.content)

def __enter__(self):
return self

def __exit__(self, exc_type, exc_val, exc_tb):

@agatti agatti Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a controversial take, but replacing the non-self arguments list with a single *_ saves 28 bytes.

I'd say it's safe to assume that a context manager will always pass the correct arguments to __exit__, although that way will look quite uglier than what you initially wrote :)

@Gadgetoid Gadgetoid Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a controversial take, but replacing the non-self arguments list with a single *_ saves 28 bytes.

I did a quick search of the codebase and picked the most common pattern. I did see *args and my personal preference would probably be _type, _value, _traceback to both flag as unused and keep it unambiguous 😆

Might not hurt to get some consensus on this and raise a PR to make every __exit__ in micropython-lib look the same.

@dpgeorge dpgeorge Jun 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using *args will lead to an allocation of a tuple at runtime whenever the function is called (to hold all the arguments).

So I suggest just keeping this as-is for now.

self.close()


def request(
method,
Expand Down
Loading