Fix CSI '=' prefix handling - #3
Open
Polymorph0us wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
CSI prefix tracking is incomplete, so some prefixed sequences (e.g., with >/<) can still be misinterpreted as unprefixed ESC[u despite the new prefix == 0 restore guard.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR fixes CSI parsing so the terminal no longer treats the kitty keyboard protocol sequence ESC[=u as the standard cursor-restore sequence ESC[u, preventing unintended cursor restoration.
Changes:
- Add explicit CSI prefix tracking (
=vs none) during CSI parse. - Gate cursor restoration (
CSI u) so it only triggers for unprefixedESC[u. - Add regression tests covering
ESC[u(restore) vsESC[=u(no restore).
File summaries
| File | Description |
|---|---|
| csi.go | Tracks a CSI prefix and uses it to avoid restoring the cursor for prefixed u sequences. |
| csi_test.go | Adds regression tests ensuring ESC[=u does not restore the cursor while ESC[u does. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed handling of the
ESC[=uCSI sequence.Previously,
ESC[=uwas parsed asESC[u, causing the terminal emulator to incorrectly restore the cursor position. This sequence is used by the kitty keyboard protocol and should not be treated as the standard cursor-restore sequence.Changes
=CSI prefix separately.ESC[u.ESC[uandESC[=u.Testing
go test ./...This addresses the
ESC[=ucompatibility issue described in micro-editor/micro#4083.