fix(web): declare the rule tokens the Dashboard reads, and guard undeclared custom properties

[mforce]

Summary

Two custom properties the app reads were never declared, and one more had been undeclared for longer:

• --rule and --rule-strong (10 reads in Dashboard.tsx, shipped by feat(web): convert the Dashboard and app shell to MUI (#829) #883 for web: convert the Dashboard to MUI — ledger desktop, field-first phone #829): every row hairline, header rule and the double rule over the total was dropped at computed-value time, with no error anywhere. Declared now in both themes: --rule is the hairline, --rule-strong is 28% ink, as DIRECTION.md defines the two rule weights.
• --accent (.named-picker-trigger:focus-visible): the focus ring fell to its literal blue fallback on every palette. It now reads --focus, the farm's focus token.

Found while #834 (link colour) walked the token consumers. Surfaced as a fix rather than an issue because the Dashboard on main is missing its rules today.

Guard, red first

web/src/styles.declared-tokens.test.ts walks every var(--x) in non-test web/src (the fake names under src/test/ excluded) and asserts each is declared in styles.css. Against main's stylesheet it fails with:

undeclared custom properties:
--rule-strong in routes/Dashboard.tsx
--rule in routes/Dashboard.tsx
--accent in styles.css

At this head it passes, with styles.test.ts, styles.elevation.test.ts and Dashboard.test.tsx (142 tests). npm run typecheck clean.

Screenshots

Before is #883's final capture on main; after is captured from the sim stack rebuilt at this head on the demo farm. Attached in a comment below.

Refs #829, #834.

[mforce]

@coderabbitai review

[coderabbitai]

Warning

Review limit reached

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c0c9c4a0-caeb-4b38-90f0-ea30994a6400

📥 Commits

Reviewing files that changed from the base of the PR and between 2e94277 and 3ff5349.

📒 Files selected for processing (2)

• web/src/styles.css
• web/src/styles.declared-tokens.test.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[mforce]

Before is main (the #883 final capture at ab6dddc, demo farm); after is this head, sim stack rebuilt, same farm, 1:1. The row hairlines, the header rules and the double rule over the total appear; nothing else changes.

[mforce]

Review round (CodeRabbit rate limited; local Codex CLI review of git diff origin/main...HEAD at 3ff5349 stood in): no correctness findings. Codex independently re-ran the guard's scan and found 53 declared tokens and no undeclared references. Loop closed at one round with no product defect.