Roll Analysis: merge Batch and Roll into one searchable panel - #1110
Draft
PabloRuizCuevas wants to merge 2 commits into
Draft
PabloRuizCuevas wants to merge 2 commits into
PabloRuizCuevas wants to merge 2 commits into
Conversation
Batch Analysis and Roll into one section, no BATCH/ROLL subtitles. A searchable roll picker (SearchableGearCombo) replaces the plain "Select Roll…" combo and the magnifying-glass Batch Analysis button: Current Roll (default) re-scans the loaded files, a saved name loads its stored baseline, and one primary Apply button runs whichever is picked. Use Luma/Color Average move below the picker+Apply row. Save and Delete stay; Delete disables on Current Roll, and Save rejects that name to avoid shadowing the picker's built-in entry. Updates docs/USER_GUIDE.md §4.4 and the onboarding tutorial's Roll Analysis / Crosstalk steps to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…report outliers Batch Analysis pools every frame's own black/white points into a roll-wide baseline using an interquartile-trimmed mean per channel, then force-applies that baseline to every frame -- including the ones just trimmed out of computing it. Those frames get the biggest mismatch of all: the baseline is, by construction, furthest from their own measured bounds. A single-channel outlier (e.g. a scene dominated by one color) shows up as a strong color cast rather than a uniform exposure shift, since each channel stretches independently. Two fixes: - Lock Bounds now actually protects a frame: Batch Analysis skips writing the roll baseline onto any frame with lock_bounds set, instead of force-re-enabling roll averaging on it every run. - NormalizationWorker now reports which frames were trimmed out of the pooled average on any channel. They still take the roll baseline like every other frame -- this is a report, not a silent exemption -- but the status line now names them, so the mismatch is visible at analysis time instead of found later by eye. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
PabloRuizCuevas
force-pushed
the
feat/roll-analysis-redesign
branch
from
September 17, 2026 10:05
c3ff053 to
2622f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges Batch Analysis and Roll into one searchable panel — no more BATCH/ROLL subtitles to disambiguate two flows that both boiled down to "pick a baseline, apply it" — then carries Batch Analysis' own Lock Bounds handling to where it belongs.
SearchableGearCombo) replaces the plain "Select Roll…" combo and the separate magnifying-glass Batch Analysis button.docs/USER_GUIDE.md(§4.3–4.4) anddocs/PIPELINE.mdare updated to match, along with the onboarding tutorial's Roll Analysis / Crosstalk steps.Testing
uv run ruff check .uv run ty check— no new diagnostics versusorigin/mainuv run pytest -q— full suite passes; only failure is the pre-existingtests/test_metadata_presets.py::TestPresetNames::test_load_tooltip_follows_a_rebindingtests/test_roll_sidebar.py,tests/test_batch_norm_wb.py,tests/test_controller.py,tests/test_section_help_dialog.py,tests/test_section_guides.pyspecifically cover the panel and the Lock Bounds/outlier fix🤖 Generated with Claude Code