Skip to content

Model Overrides data issue #321

Description

@chymb

Good day,
Love the project, so much so that I was looking into importing model types into one of our systems but found some inaccuracies that I think are limited to the ModelOverrides.json stuff.

I only had limited data in our older system to compare it with and at least found the following board IDs don't match to the correct model identifier. This is the data I was comparing SOFA with:

board identifier
Mac-F60DEB81FF30ACF6 MacPro6,1
Mac-7BA5B2DFE22DDD8C Macmini8,1
Mac-35C5E08120C7EEAF Macmini7,1
Mac-5F9802EFE386AA28 MacBookPro16,2
Mac-E1008331FDC96864 MacBookPro16,1
Mac-53FDB3D8DB8CA971 MacBookPro15,4
Mac-1E7E29AD0135F9BC MacBookPro15,3
Mac-827FB448E656EC26 MacBookPro15,2
Mac-937A206F2EE63C01 MacBookPro15,1
Mac-CAD6701F7CEA0921 MacBookPro14,2
Mac-B4831CEBD52A0C4C MacBookPro14,1
Mac-A5C67F76ED83108C MacBookPro13,3
Mac-66E35819EE2D0D05 MacBookPro13,2
Mac-473D31EABEB93F9B MacBookPro13,1
Mac-E43C1C25D4880AD6 MacBookPro12,1
Mac-06F11F11946D27C5 MacBookPro11,5
Mac-06F11FD93F0323C5 MacBookPro11,4
Mac-0CFF9C7C2B63DF8D MacBookAir9,1
Mac-226CB3C6A851A671 MacBookAir8,2
Mac-937CB26E2E02BB01 MacBookAir7,2
Mac-9AE82516C7C6B903 MacBook9,1
Mac-B809C3757DA9BB8D iMac17,1
Mac-42FD25EABCABB274 iMac15,1

Some of those board IDs are included in the list but with different model identifiers so, hopefully, it's just a misalignment and reasonably trivial to fix.

Thanks,
Chris

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions