Skip to content

tickets/SP-2430-review#164

Open
sgreenstreet wants to merge 1 commit into
tickets/SP-2430from
tickets/SP-2430-review
Open

tickets/SP-2430-review#164
sgreenstreet wants to merge 1 commit into
tickets/SP-2430from
tickets/SP-2430-review

Conversation

@sgreenstreet

Copy link
Copy Markdown
Contributor

Reviewed notebook. Content looks good - this will be a nice addition to the 308 series notebooks. Made several small edits to follow guidelines in https://rtn-045.lsst.io/ and after running flake8-nb.

Notes from review:

  • Ran flake8-nb and made edits accordingly (mostly fixing indenting and spacing).
  • Updated header markdown cell to include all packages used.
  • Edited some terminology and wording in markdown cells and section titles to be more consistent with other notebooks & RTN-045 guidelines.
  • Rearranged query structures to be consistent with other notebooks.
  • Added additional markdown cells with descriptions of following cells where missing.
  • Moved the exercise for the learner embedded in Section 3 to a separate section at the end of the notebook.
  • Edited plot titles slightly for easier reading.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sgreenstreet sgreenstreet requested a review from jrob93 July 1, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant