Skip to content

fix(livekit-agents): require livekit-protocol>=1.1.21 for MetricsRecordingHeader.simulated#6541

Merged
u9g merged 1 commit into
mainfrom
fix/livekit-protocol-floor
Jul 24, 2026
Merged

fix(livekit-agents): require livekit-protocol>=1.1.21 for MetricsRecordingHeader.simulated#6541
u9g merged 1 commit into
mainfrom
fix/livekit-protocol-floor

Conversation

@u9g

@u9g u9g commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Why

#6497 added simulation/redaction telemetry tagging: telemetry/traces.py now builds MetricsRecordingHeader(..., simulated=..., redaction_enabled=...) in the session-report upload. But it left the dependency floor at livekit-protocol>=1.1.19,<2, and those proto fields were only added in livekit-protocol 1.1.21 (proto side of livekit/protocol#1679; Go equivalent shipped in v1.50.4).

As a result, any install that resolves livekit-protocol to the floor (1.1.19 or 1.1.20 — non-locked installs, e.g. pip install livekit-agents) crashes on every session-report upload:

ValueError: Protocol message MetricsRecordingHeader has no "simulated" field
  at telemetry/traces.py in _upload_session_report

Because the upload fails, the recorded chat_history is never stored, which in turn makes the simulation summarizer 404-loop fetching it.

What

  • Bump the livekit-protocol floor to >=1.1.21,<2 — the first release that defines MetricsRecordingHeader.simulated / redaction_enabled — so the declared dependency actually guarantees the fields feat: tag simulation and redaction telemetry #6497 writes.
  • Re-lock (uv lock): the resolved version was already 1.1.21, so this is a one-line specifier update with no package churn.

Verified

With livekit-protocol==1.1.21 installed, a lk agent simulate run uploads the session report cleanly (uploading session reportfinished uploading) and the exported run JSON retains full function_call.arguments and function_call_output.output (redaction is skipped for simulation sessions).

…rdingHeader.simulated

#6497 writes MetricsRecordingHeader.simulated / redaction_enabled
in the session-report upload, but left the dependency floor at
livekit-protocol>=1.1.19, which predates those proto fields (added in 1.1.21).
A non-locked install resolving to the floor crashes the entire session-report
upload with 'MetricsRecordingHeader has no "simulated" field', dropping the
recorded chat history. Bump the floor to the first release that defines them.
@u9g
u9g requested a review from a team as a code owner July 24, 2026 17:26

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@u9g
u9g merged commit 1d7a444 into main Jul 24, 2026
25 checks passed
@u9g
u9g deleted the fix/livekit-protocol-floor branch July 24, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants