Skip to content

fix(tinybird): quarantine on organizations — IN-1209#4395

Open
joanagmaia wants to merge 1 commit into
mainfrom
autofix/tb-quarantine/IN-1209
Open

fix(tinybird): quarantine on organizations — IN-1209#4395
joanagmaia wants to merge 1 commit into
mainfrom
autofix/tb-quarantine/IN-1209

Conversation

@joanagmaia

Copy link
Copy Markdown
Contributor

Summary

Fixes quarantine on organizations datasource.

Root cause: Null value not allowed on column displayName (strict type checking)
Offending columns: displayName
Fix: Add null guard / empty string fallback for displayName before Tinybird ingest.

Related: IN-1209
Quarantined rows: 907

Auto-generated by tinybird-quarantine-autofix skill. Human review required before merge.

displayName is non-nullable but null values sent from producer. Add null guard.

Jira: IN-1209
Copilot AI review requested due to automatic review settings July 24, 2026 16:34
@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Two-line null guard on GitHub organization mapping only; no auth or broader pipeline changes.

Overview
Fixes Tinybird organizations quarantine when GitHub org metadata has a missing name.

In parseMember, organization payloads built from a member’s company now set displayName and names with orgs.name || '' instead of passing through a null/undefined name, matching the non-null displayName requirement on ingest.

Reviewed by Cursor Bugbot for commit ade4e78. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ade4e78. Configure here.

displayName: orgs.name,
names: [orgs.name],
displayName: orgs.name || '',
names: [orgs.name || ''],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty displayName causes org merge collision

High Severity

When GitHub returns no organization name, displayName and names are set to ''. findOrCreateOrganization then falls back to findOrganizationsByName, which treats all trimmed-empty display names as equal, so unrelated GitHub orgs can be merged and members linked to the wrong organization.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ade4e78. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds empty-string fallbacks intended to prevent null organization names from reaching Tinybird.

Changes:

  • Guards GitHub organization displayName and names.
  • Does not repair persisted null rows or quarantined records.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

const organizationPayload = {
displayName: orgs.name,
names: [orgs.name],
displayName: orgs.name || '',
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants