fix(tinybird): quarantine on organizations — IN-1209#4395
Conversation
displayName is non-nullable but null values sent from producer. Add null guard. Jira: IN-1209
PR SummaryLow Risk Overview In Reviewed by Cursor Bugbot for commit ade4e78. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ade4e78. Configure here.
| displayName: orgs.name, | ||
| names: [orgs.name], | ||
| displayName: orgs.name || '', | ||
| names: [orgs.name || ''], |
There was a problem hiding this comment.
Empty displayName causes org merge collision
High Severity
When GitHub returns no organization name, displayName and names are set to ''. findOrCreateOrganization then falls back to findOrganizationsByName, which treats all trimmed-empty display names as equal, so unrelated GitHub orgs can be merged and members linked to the wrong organization.
Reviewed by Cursor Bugbot for commit ade4e78. Configure here.
There was a problem hiding this comment.
Pull request overview
Adds empty-string fallbacks intended to prevent null organization names from reaching Tinybird.
Changes:
- Guards GitHub organization
displayNameandnames. - Does not repair persisted null rows or quarantined records.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const organizationPayload = { | ||
| displayName: orgs.name, | ||
| names: [orgs.name], | ||
| displayName: orgs.name || '', |


Summary
Fixes quarantine on
organizationsdatasource.Root cause: Null value not allowed on column displayName (strict type checking)
Offending columns: displayName
Fix: Add null guard / empty string fallback for displayName before Tinybird ingest.
Related: IN-1209
Quarantined rows: 907