LCORE-2952: updated pipelines - #2355
Conversation
WalkthroughThe 0.7 pull-request and push PipelineRuns were removed. The 0.8 PipelineRuns now build x86_64 and ARM64 images, prefetch dependencies, refresh task bundles, configure Snyk and Coverity scans, add push tagging, and enforce four-hour timeouts. Integration-test pipelines now target 0.8. ChangesKonflux pipeline refresh
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant PipelineRun
participant dependency-prefetch
participant remote-Buildah
participant Snyk
participant Coverity-check
participant Coverity-SAST
PipelineRun->>dependency-prefetch: Prefetch configured dependencies
dependency-prefetch->>remote-Buildah: Supply build inputs
remote-Buildah->>Snyk: Supply image and artifact inputs
PipelineRun->>Coverity-check: Check scanner availability
Coverity-check->>Coverity-SAST: Run conditional SAST scan
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
|
/retest |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/lightspeed-stack-0-8-pull-request.yaml:
- Around line 519-563: Rename the Coverity task currently named sast-shell-check
to sast-coverity-check in both .tekton/lightspeed-stack-0-8-pull-request.yaml
lines 519-563 and .tekton/lightspeed-stack-0-8-push.yaml lines 516-560; leave
the separate task resolving sast-shell-check-oci-ta unchanged.
- Around line 172-195: Remove the duplicate Pipeline parameter declarations,
retaining exactly one declaration for each named parameter in
.tekton/lightspeed-stack-0-8-pull-request.yaml lines 172-195:
enable-cache-proxy, enable-package-registry-proxy, sast-target-dirs,
source-date-epoch, rewrite-timestamp, and omit-history; apply the same cleanup
in .tekton/lightspeed-stack-0-8-push.yaml lines 173-192 for
enable-package-registry-proxy, sast-target-dirs, source-date-epoch,
rewrite-timestamp, and omit-history.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: df44e7a4-a5bf-4251-b41b-287cc3dffe2f
📒 Files selected for processing (4)
.tekton/lightspeed-stack-0-7-pull-request.yaml.tekton/lightspeed-stack-0-7-push.yaml.tekton/lightspeed-stack-0-8-pull-request.yaml.tekton/lightspeed-stack-0-8-push.yaml
💤 Files with no reviewable changes (2)
- .tekton/lightspeed-stack-0-7-pull-request.yaml
- .tekton/lightspeed-stack-0-7-push.yaml
📜 Review details
⏰ Context from checks skipped due to timeout. (6)
- GitHub Check: E2E: library mode / ci / group 1
- GitHub Check: E2E: library mode / ci / group 2
- GitHub Check: E2E: server mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 2
- GitHub Check: E2E: library mode / ci / group 3
- GitHub Check: E2E: server mode / ci / group 3
⚠️ CI failures not shown inline (5)
GitHub Actions: E2E Tests for Lightspeed Evaluation / 0_E2E Tests for Lightspeed Evaluation job.txt: updated pipelines
Conclusion: failure
lightspeed-stack | ERROR Application startup failed. Exiting. category=server
Still waiting...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (7) Failed to connect to localhost port 8080 after 0 ms: Couldn't connect to server
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/fastapi/routing.py", line 240, in merged_lifespan
lightspeed-stack | async with original_context(app) as maybe_original_state:
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/usr/lib64/python3.12/contextlib.py", line 210, in __aenter__
lightspeed-stack | return await anext(self.gen)
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/app-root/src/app/main.py", line 86, in lifespan
lightspeed-stack | await AsyncOgxClientHolder().load(llama_stack_config)
lightspeed-stack | File "/app-root/src/client.py", line 49, in load
lightspeed-stack | await self._load_library_client(llama_stack_config)
lightspeed-stack | File "/app-root/src/client.py", line 82, in _load_library_client
lightspeed-stack | await client.initialize()
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/ogx/core/library_client.py", line 413, in initialize
lightspeed-stack | await self.stack.initialize() # type: ignore
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/ogx/core/stack.py", line 753, in initialize
lightspeed-stack | impls = await reso...
GitHub Actions: E2E Tests for Lightspeed Evaluation / E2E Tests for Lightspeed Evaluation job: updated pipelines
Conclusion: failure
lightspeed-stack | ERROR Application startup failed. Exiting. category=server
Still waiting...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (7) Failed to connect to localhost port 8080 after 0 ms: Couldn't connect to server
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/fastapi/routing.py", line 240, in merged_lifespan
lightspeed-stack | async with original_context(app) as maybe_original_state:
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/usr/lib64/python3.12/contextlib.py", line 210, in __aenter__
lightspeed-stack | return await anext(self.gen)
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/app-root/src/app/main.py", line 86, in lifespan
lightspeed-stack | await AsyncOgxClientHolder().load(llama_stack_config)
lightspeed-stack | File "/app-root/src/client.py", line 49, in load
lightspeed-stack | await self._load_library_client(llama_stack_config)
lightspeed-stack | File "/app-root/src/client.py", line 82, in _load_library_client
lightspeed-stack | await client.initialize()
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/ogx/core/library_client.py", line 413, in initialize
lightspeed-stack | await self.stack.initialize() # type: ignore
lightspeed-stack | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lightspeed-stack | File "/app-root/.venv/lib64/python3.12/site-packages/ogx/core/stack.py", line 753, in initialize
lightspeed-stack | impls = await reso...
GitHub Actions: E2E Tests for Lightspeed Evaluation / E2E Tests for Lightspeed Evaluation job: updated pipelines
Conclusion: failure
##[group]Run echo "=== Test failure logs ==="
�[36;1mecho "=== Test failure logs ==="�[0m
�[36;1mecho "=== lightspeed-stack (library mode) logs ==="�[0m
�[36;1mdocker compose -f docker-compose-library.yaml logs lightspeed-stack�[0m
shell: /usr/bin/bash -e {0}
env:
OPENAI_***REDACTED_SECRET_ASSIGNMENT***
E2E_OPENAI_MODEL: gpt-4o-mini
FAISS_VECTOR_STORE_ID: vs_8c94967b-81cc-4028-a294-9cfac6fd9ae2
##[endgroup]
=== Test failure logs ===
=== lightspeed-stack (library mode) logs ===
lightspeed-stack | .882 INFO: Lightspeed Core Stack startup [lightspeed_stack.__main__:160]
lightspeed-stack | .885 INFO: Configuration: name='Lightspeed Core Service (LCS)' service=ServiceConfiguration(host='0.0.0.0', port=8080, base_url=None, auth_enabled=False, workers=1, color_log=True, access_log=True, tls_config=TLSConfiguration(tls_certificate_path=None, tls_key_path=None, tls_key_***REDACTED_SECRET_ASSIGNMENT*** root_path='', cors=CORSConfiguration(allow_origins=['*'], allow_credentials=False, allow_methods=['*'], allow_headers=['*'])) llama_stack=LlamaStackConfiguration(url=AnyHttpUrl('http://localhost:8321/'), ***REDACTED_SECRET_ASSIGNMENT*** use_as_library_client=True, library_client_config_path='/app-root/run.yaml', timeout=180, max_retries=5, retry_delay=2, allow_degraded_mode=False, config=None) user_data_collection=UserDataCollection(feedback_enabled=True, feedback_storage='/tmp/data/feedback', transcripts_enabled=True, transcripts_storage='/tmp/data/transcripts') database=DatabaseConfiguration(sqlite=SQLiteDatabaseConfiguration(db_path='/tmp/lightspeed-stack.db'), postgres=None) mcp_servers=[] authentication=AuthenticationConfiguration(module='noop', skip_tls_verification=False, skip_for_health_probes=False, skip_for_metrics=False, k8s_cluster_api=None, k8s_ca_cert_path=None, jwk_config=None, api_key_config=None, rh_identity_config=None, trusted_proxy_config=None) authorization=None customization=None inference=InferenceConfiguration(default_mod...
GitHub Actions: PR Title Checker / 0_check.txt: updated pipelines
Conclusion: failure
##[group]Run thehanimo/pr-title-checker@v1.4.3
with:
GITHUB_***REDACTED_SECRET_ASSIGNMENT***
pass_on_octokit_error: false
configuration_path: .github/pr-title-checker-config.json
##[endgroup]
(node:2127) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
Using config file .github/pr-title-checker-config.json from repo lightspeed-core/lightspeed-stack [ref: 20d053cd5033b32377e8cc45010adcbe7716fe3a]
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:2127) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
Creating label (title needs formatting)...
Label (title needs formatting) already created.
Adding label (title needs formatting) to PR...
HttpError: Resource not accessible by integration
##[error]Failed to add label (title needs formatting) to PR
GitHub Actions: PR Title Checker / check: updated pipelines
Conclusion: failure
##[group]Run thehanimo/pr-title-checker@v1.4.3
with:
GITHUB_***REDACTED_SECRET_ASSIGNMENT***
pass_on_octokit_error: false
configuration_path: .github/pr-title-checker-config.json
##[endgroup]
(node:2127) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
Using config file .github/pr-title-checker-config.json from repo lightspeed-core/lightspeed-stack [ref: 20d053cd5033b32377e8cc45010adcbe7716fe3a]
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:2127) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
Creating label (title needs formatting)...
Label (title needs formatting) already created.
Adding label (title needs formatting) to PR...
HttpError: Resource not accessible by integration
##[error]Failed to add label (title needs formatting) to PR
🔇 Additional comments (2)
.tekton/lightspeed-stack-0-8-pull-request.yaml (1)
32-68: LGTM!Also applies to: 219-219, 240-240, 266-266, 330-330, 352-352, 373-373, 422-422, 447-447, 462-469, 504-504, 650-650, 673-673, 690-690, 704-706
.tekton/lightspeed-stack-0-8-push.yaml (1)
5-8: LGTM!Also applies to: 33-69, 216-216, 237-237, 263-263, 327-327, 349-349, 370-370, 419-419, 444-444, 459-466, 501-501, 640-650, 673-673, 690-690, 704-706
6d20a06 to
c097d83
Compare
Description
Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit