Adopt the claude-rules library-team profile as the shared ruleset - #22
Merged
Conversation
The flat rule files under .claude/rules/ were hand-copied early on and had drifted from the shared modules in the claude-rules repo. Replace them with the library-team profile (core x5, library archetype, team workflow, benchmarks overlay) copied verbatim via tools/sync.ps1, so future drift is auditable with the script's check mode. Sqlbound-only conventions (milestone planning, feature/M-number branches, phase-based semver, Roslyn snapshot testing, Dapper/ADO.NET benchmark baselines) move to a project-specific rule file outside the synced set, keeping the shared modules byte-identical to their source. The EF Core records exception is dropped deliberately: SqlBound builds on System.Data.Common and never maps EF entities. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The drift audit covers nine files including `profiles/library-team.md`, but the project rule file named only `core/`, `archetype/`, and `overlays/` as never-edit-here, leaving the profile manifest it imports unprotected by the same instruction. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The prerelease rule described only an `X.Y.0-preview.N` line dropping to a clean `X.Y.0` at phase close, but Phase 6 went straight from `0.5.0` to `1.0.0-rc.1` and was tagged mid-phase on that suffixed version, with the milestone deliberately left open until GA. The milestone-title template said `(0.Y.x)`, which the live `Phase 6 - Ship (1.0.x)` does not fit. Two adjacent bullets carried the same drift: tagging was described as happening only at phase completion, and a phase was said to get its own minor version though Phase 6 took a major bump. This file is loaded as project instructions, so a wrong rule gets followed. State instead the tag-matches-PackageVersion invariant that actually holds across all six tags, cover both the `-preview.N` and `-rc.N` lines, and spell out the remaining GA promotion so the open Phase 6 can be finished from the rule alone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The flat rule files under
.claude/rules/were hand-copied early on and had drifted from the shared modules in theclaude-rulesrepo — missing newer upstream rules (the TDD porting exception, theN-reference autolink hygiene rule, the benchmarks--job Drysmoke test, the library archetype's semver-contract and OS-matrix CI rules) and carrying content that doesn't belong here (an EF Core records exception; SqlBound builds onSystem.Data.Commonand never maps EF entities).What
library-teamprofile (5core/modules,archetype/library,overlays/workflow-team,overlays/benchmarks) copied verbatim viatools/sync.ps1, so future drift is auditable with-Check.feature/M<number>-<desc>branches, phase-based semver with tags and thePackageVersionprerelease scheme, GitHub milestone-per-phase, Roslyn snapshot testing, Dapper/ADO.NET benchmark baselines, the "one.slnxper repo or example" extension — into a new.claude/rules/project/sqlbound.mdoutside the synced set, keeping the shared modules byte-identical to their source.CLAUDE.mdConventions section at the profile manifest plus the project file.-rc.Nline alongside-preview.Nand states the tag-matches-PackageVersioninvariant that holds across all six tags; release-candidate tagging is documented as leaving the phase open, with the remaining GA promotion spelled out; the milestone template readsPhase N — <Name> (<major>.<minor>.x)so it fitsPhase 6 — Ship (1.0.x); and a phase gets its own "version line" rather than "minor version", since Phase 6 took a major bump.Verification
sync.ps1 -Checkreports all 9 synced files in sync withlibrary-team.@importpath referenced fromCLAUDE.mdand the profile manifest resolves on disk.v0.1.0–v0.5.0,v1.0.0-rc.1), the fullPackageVersionhistory inDirectory.Build.props, theCHANGELOG.mdheadings, and the six live GitHub milestone titles.🤖 Generated with Claude Code