Skip to content

Update ROCm releases to 7.14.0#1802

Open
superm1 wants to merge 1 commit into
leejet:masterfrom
lemonade-sdk:master
Open

Update ROCm releases to 7.14.0#1802
superm1 wants to merge 1 commit into
leejet:masterfrom
lemonade-sdk:master

Conversation

@superm1

@superm1 superm1 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

7.14.0 is a production release from AMD. Drop the previous stable artifacts and only create production artifacts.

Increase hardware support to more devices included with 7.14.0.

Checklist

@kenvandine

Copy link
Copy Markdown

The windows-latest-rocm job's "Pack artifacts" step used to explicitly copy rocblas*.dll / hipblas*.dll and the rocblas\library / hipblaslt\library kernel directories from $HIP_PATH\bin into build\bin before zipping. That copy block was removed here — the step now just runs 7z a ... .\build\bin\* directly.

I don't see anything else that would put those files into build\bin on Windows: cmake --build . doesn't copy runtime DLL dependencies, and there's no post-build copy/install step in either stable-diffusion.cpp's CMakeLists.txt or ggml's ggml-hip/CMakeLists.txt (checked both at this PR's head commit / pinned ggml submodule).

Since HIP_PATH now points into the pip-installed rocm-sdk wheel tree instead of the old tarball's C:\TheRock\build, the released sd-*-bin-win-rocm-7.14.0-x64.zip may end up missing rocblas.dll/hipblas*.dll and rocBLAS's adjacent library folder (Tensile kernels), which would break sd.exe for anyone running it without ROCm already installed. Worth double-checking the packaged zip actually contains those files before this merges.

@superm1

superm1 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

The windows-latest-rocm job's "Pack artifacts" step used to explicitly copy rocblas*.dll / hipblas*.dll and the rocblas\library / hipblaslt\library kernel directories from $HIP_PATH\bin into build\bin before zipping. That copy block was removed here — the step now just runs 7z a ... .\build\bin\* directly.

I don't see anything else that would put those files into build\bin on Windows: cmake --build . doesn't copy runtime DLL dependencies, and there's no post-build copy/install step in either stable-diffusion.cpp's CMakeLists.txt or ggml's ggml-hip/CMakeLists.txt (checked both at this PR's head commit / pinned ggml submodule).

Since HIP_PATH now points into the pip-installed rocm-sdk wheel tree instead of the old tarball's C:\TheRock\build, the released sd-*-bin-win-rocm-7.14.0-x64.zip may end up missing rocblas.dll/hipblas*.dll and rocBLAS's adjacent library folder (Tensile kernels), which would break sd.exe for anyone running it without ROCm already installed. Worth double-checking the packaged zip actually contains those files before this merges.

That was an intentional change because of how multiarch and rocm-sdk works. When a user installs the rocm-sdk they should pull down these DLL's. This also mirrors how another ggml project's ROCM 7.14 PR (llama.cpp) works.

@superm1

superm1 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@ramkrishna2910 can you please validate I got this right on Windows?

@JohnLoveJoy

Copy link
Copy Markdown

Gfx900 and Gfx90c are now supported by ROCm as well.

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
7.14.0 is a production release from AMD.  Drop the previous stable
artifacts and only create production artifacts.

Increase hardware support to more devices included with 7.14.0.
@superm1

superm1 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Gfx900 and Gfx90c are now supported by ROCm as well.

Yes; but only for Linux. I've adjusted the jobs for only enabling GFX9 on Linux.

The installed ROCm version is not pinned.

Now pinned.

However, gfx1153 is currently missing from both the Windows and Linux GPU_TARGETS lists.

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants