refactor(ClassicalMechanics): switch to derivVec for simple-pendulum velocity - #1604
Conversation
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
S.spaceTrajectory θ : Time → Space 2is the bob's position, a curve of points, sodifferentiating it with
Time.derivgave a velocity typed as a point ofSpace 2—the docstring described it as "the vector tangent to the circle" while the type said
otherwise. This retypes it with
derivVec(#1592), so the velocity is valued inEuclideanSpace ℝ (Fin 2).Nothing changes numerically: both norms are the L² norm on coordinates.
AI disclosure: assisted in checking and PR summary, code is written by myself