refactor(ClassicalMechanics): switch to derivVec for rigid-body velocities and momentum - #1603
Conversation
…ed in the displacement space
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
Time.derivsendsTime → MtoTime → M, so a trajectory of points previously had its velocity typed as a point.RigidBodyMotion.centerOfMassVelocitywasTime → Space d, andlinearMomentuminherited it, making momentum a position. This PR retypes them usingderivVec(#1592), so velocities and momentum are valued in the displacement spaceEuclideanSpace ℝ (Fin d).AI disclosure: assisted in checking and PR summary, code is written by myself