Require PHP 8.0 for compatibility with firebase/php-jwt#47
Open
fadrian06 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the package’s minimum PHP version to avoid installation failures now that firebase/php-jwt no longer supports PHP 7.4.
Changes:
- Add a PHP platform requirement (
php >= 8.0) tocomposer.json. - Update Rector configuration to target PHP 8.0 downgrade set and adjust import-name handling configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
composer.json |
Declares PHP 8+ as a requirement to align with dependency constraints. |
rector.php |
Updates Rector downgrade set to PHP 8.0 and modifies import name configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (pls check at least one)
Description
This PR fixes an issue when trying to install this library in a project using PHP 7.4, as firebase/php-jwt has dropped support for PHP 7.4. If the breaking changes introduced by this PR prevent it from being merged, I’ll remove it and look for alternatives to firebase/php-jwt that support PHP 7.4.
Does this PR introduce a breaking change? (check one)