allow to use league/oauth2-google without leafs/leaf#46
Open
fadrian06 wants to merge 10 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the hard dependency on Leaf’s _env() helper for Google OAuth auto-configuration so league/oauth2-google can be used without requiring leafs/leaf.
Changes:
- Replace direct
_env()usage in Google OAuth auto-setup with an internalenv()helper. - Add
Auth::env()to read environment variables with Leaf_env()as a preferred source. - Bump
league/oauth2-googledev dependency from^4.0to^5.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/Auth.php |
Introduces env() helper and updates Google OAuth auto-setup/default redirect URI logic to use it. |
composer.json |
Updates league/oauth2-google version in require-dev. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fadrian06
force-pushed
the
google-client-without-app
branch
from
2581405 to
8edb09c
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@mychidarko please review this old PR, please |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fadrian06
force-pushed
the
google-client-without-app
branch
from
b403c43 to
f7a8588
Compare
fadrian06
force-pushed
the
google-client-without-app
branch
from
eccfe90 to
88253c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (pls check at least one)
Description
Previously you have to install both league/oauth2-google and leafs/leaf to call ->withGoogle() within __construct().
Does this PR introduce a breaking change? (check one)