Skip to content

chore: enforce npm min-release-age dependency cooldown #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joker23 merged 11 commits into from
Aug 10, 2026
Merged

chore: enforce npm min-release-age dependency cooldown #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
239b89d
chore: enforce npm min-release-age dependency cooldown
devin-ai-integration[bot] Aug 6, 2026
faf019f
chore: retrigger ci
devin-ai-integration[bot] Aug 6, 2026
210d24d
chore: exempt LaunchDarkly SDK packages from the cooldown
devin-ai-integration[bot] Aug 7, 2026
f0d644f
chore: limit cooldown exemptions to packages actually used
devin-ai-integration[bot] Aug 7, 2026
9b5c45c
chore: exempt transitive first-party packages from the cooldown
devin-ai-integration[bot] Aug 7, 2026
411bd13
ci: use npm 12 in release workflow so the cooldown applies to releases
devin-ai-integration[bot] Aug 7, 2026
2862589
ci: rely on the runner's bundled npm for release builds
devin-ai-integration[bot] Aug 10, 2026
020757d
ci: run on node 24 and use its bundled npm
devin-ai-integration[bot] Aug 10, 2026
cb3f36e
ci: install npm 11.17 since the runner image ships 11.16
devin-ai-integration[bot] Aug 10, 2026
a04d73e
ci: require node >=24.19.0 so bundled npm supports the age gate
devin-ai-integration[bot] Aug 10, 2026
e62f4cb
ci: drop manual npm install now that node 24.19 bundles npm 11.17
devin-ai-integration[bot] Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
matrix:
variations: [
# {os: ubuntu-latest, node: latest},
{os: ubuntu-latest, node: 'lts/*'},
{os: ubuntu-latest, node: '^24.19.0'},
Comment thread
kinyoklion marked this conversation as resolved.
]

runs-on: ${{ matrix.variations.os }}
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,9 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 24.x
node-version: '^24.19.0'
registry-url: 'https://registry.npmjs.org'

- name: Update NPM
shell: bash
# Must be greater than 11.5.1 for OIDC.
Comment thread
cursor[bot] marked this conversation as resolved.
run: npm install -g npm@11.6.2

- name: Install Dependencies
run: npm install
Expand Down Expand Up @@ -81,13 +77,9 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 24.x
node-version: '^24.19.0'
registry-url: 'https://registry.npmjs.org'

- name: Update NPM
shell: bash
# Must be greater than 11.5.1 for OIDC.
run: npm install -g npm@11.6.2

- name: Install Dependencies
run: npm install
Expand Down
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ docs/build/
yarn.lock
package-lock.json
pnpm-lock.yaml
.npmrc
docs/
3 changes: 3 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
min-release-age=3

@devin-ai-integration devin-ai-integration Bot Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Dependency cooling-off period is effectively disabled because the wait time is far shorter than intended

The minimum wait before a newly published dependency may be installed is set to 3 (min-release-age=3 in .npmrc:1), but the setting is interpreted in minutes rather than days, so packages published only three minutes ago are still installed.
Impact: The safeguard meant to avoid pulling in just-published (potentially compromised) dependency versions provides almost no protection.

npm config units for min-release-age

npm's min-release-age config is a number of minutes, not days. The accompanying comments in .github/workflows/ci.yml:32 and .github/workflows/release-please.yml:50 indicate the intent is to use the exclusion list to allow LaunchDarkly's own freshly published packages, implying a meaningful cooling-off window for everything else. A 3-day window would need min-release-age=4320.

Suggested change
min-release-age=3
min-release-age=4320
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@kinyoklion kinyoklion Aug 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is days.

@devin-ai-integration devin-ai-integration Bot Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — it's days (docs), so 3 is the intended 3-day window and the suggestion is wrong. Same conclusion as the earlier thread on node-client-sdk#77; no change needed.

min-release-age-exclude[]=launchdarkly-js-client-sdk
min-release-age-exclude[]=launchdarkly-js-sdk-common
Loading