LATX, AVX: avoid loading overwritten VPMOVSX destinations - #445
Draft
luzeng87 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Lu Zeng <luzeng87@gmail.com>
luzeng87
force-pushed
the
avx-vpmovsx-pure-dest
branch
from
September 2, 2026 10:45
4b69fe7 to
8331caa
Compare
Contributor
Author
|
Correctness review found that the production change is in translate_vaddsubpd(), while the PR and test describe VPMOVSX. Moving the allocation change to translate_vpmovsxxx() then fails the destination/source alias case in a clean LoongArch JIT, cold-AOT, and hot-AOT check. Closing this PR instead of merging a mis-targeted or unverified optimization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VPMOVSX fully overwrites its destination. Loading the old destination can materialize upper-half state that the extension immediately replaces.
Validation