docs(calendar): clarify identity selection for scheduling - #2280
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe calendar skill maps “我” to the logged-in user and “你” to the bot. It documents explicit caller attendee handling for event creation and attendee addition. ChangesCalendar identity guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@fda9ce15148e8d072891950c4a99362149e445e2🧩 Skill updatenpx skills add larksuite/cli#docs/calendar-identity-pronoun-mapping -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
+ Coverage 76.44% 76.47% +0.02%
==========================================
Files 1013 1013
Lines 111957 112079 +122
==========================================
+ Hits 85588 85707 +119
Misses 19859 19859
- Partials 6510 6513 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3924988 to
3b6cdde
Compare
3b6cdde to
5be74fa
Compare
Agents misread colloquial pronouns when creating events. Two fixes in the calendar skill: - SKILL.md: pronouns that are field values (attendees, meeting owner) do not participate in `--as` identity selection, so "会议 owner 为我" no longer flips bot-identity creation to user identity. "我" = the logged-in user, "你" = the application (bot). - create.md: the raw calendar events/attendees API does not auto-add the calling identity as +create does; guide callers to add the caller's open_id as a user attendee when using the full API flow.
5be74fa to
fda9ce1
Compare
Summary
Agents misread colloquial pronouns when creating calendar events, picking the wrong
--asidentity and dropping fields. This clarifies the calendar skill so identity selection is robust, and documents a gap when using the raw API.Two concrete problems this fixes:
--as user), because the pronoun "我" appearing as a field value (meeting owner) leaked into identity selection. The meeting owner was also silently dropped.calendar events/event.attendeesAPI did not add the calling identity as an attendee, unlike+createwhich does this automatically.Changes
skills/lark-calendar/SKILL.md: pronouns that are only field values (attendees, meeting owner, …) do not participate in--asidentity selection. Keep the mapping "我" = logged-in user, "你" = application (bot); e.g. "你创建日程,邀请我、会议 owner 为我" → create with--as bot, logged-in user is only an attendee / meeting owner.skills/lark-calendar/references/lark-calendar-create.md: note that the rawcalendar events create/calendar event.attendees createAPI does not auto-add the calling identity the way+createdoes. Guide callers to add the caller'sopen_idas atype:userattendee (bot vialark-cli api GET /open-apis/bot/v3/info --as bot→bot.open_id; user vialark-cli auth status --json --verify→identities.user.openId).Test Plan
node scripts/skill-format-check/index.jspassesRelated Issues
Summary by CodeRabbit