Skip to content

docs(calendar): clarify identity selection for scheduling - #2280

Merged
calendar-assistant merged 1 commit into
mainfrom
docs/calendar-identity-pronoun-mapping
Aug 11, 2026
Merged

docs(calendar): clarify identity selection for scheduling#2280
calendar-assistant merged 1 commit into
mainfrom
docs/calendar-identity-pronoun-mapping

Conversation

@calendar-assistant

@calendar-assistant calendar-assistant commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Agents misread colloquial pronouns when creating calendar events, picking the wrong --as identity and dropping fields. This clarifies the calendar skill so identity selection is robust, and documents a gap when using the raw API.

Two concrete problems this fixes:

  • "你创建日程…指定会议 owner 为我" was misread as the logged-in user creates the event (used --as user), because the pronoun "我" appearing as a field value (meeting owner) leaked into identity selection. The meeting owner was also silently dropped.
  • Callers falling back to the raw calendar events / event.attendees API did not add the calling identity as an attendee, unlike +create which does this automatically.

Changes

  • skills/lark-calendar/SKILL.md: pronouns that are only field values (attendees, meeting owner, …) do not participate in --as identity selection. Keep the mapping "我" = logged-in user, "你" = application (bot); e.g. "你创建日程,邀请我、会议 owner 为我" → create with --as bot, logged-in user is only an attendee / meeting owner.
  • skills/lark-calendar/references/lark-calendar-create.md: note that the raw calendar events create / calendar event.attendees create API does not auto-add the calling identity the way +create does. Guide callers to add the caller's open_id as a type:user attendee (bot via lark-cli api GET /open-apis/bot/v3/info --as botbot.open_id; user via lark-cli auth status --json --verifyidentities.user.openId).

Test Plan

  • node scripts/skill-format-check/index.js passes
  • Docs-only change; no Go code affected

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Clarified conversational pronouns in calendar interactions: “我” refers to the logged-in user, while “你” refers to the bot.
    • Clarified that attendees or owners listed in event fields do not determine which identity performs an action.
    • Added guidance that the caller’s ID must be explicitly included when adding them as an attendee.
    • Documented how to retrieve bot and user IDs and avoid duplicate attendees.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f13e20d6-0c73-4f9e-9523-60995bb582fc

📥 Commits

Reviewing files that changed from the base of the PR and between 5be74fa and fda9ce1.

📒 Files selected for processing (1)
  • skills/lark-calendar/references/lark-calendar-create.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/lark-calendar/references/lark-calendar-create.md

📝 Walkthrough

Walkthrough

The calendar skill maps “我” to the logged-in user and “你” to the bot. It documents explicit caller attendee handling for event creation and attendee addition.

Changes

Calendar identity guidance

Layer / File(s) Summary
Pronoun mapping and bot identity example
skills/lark-calendar/SKILL.md
The instructions map conversational pronouns to the logged-in user or bot. The example uses --as bot when the bot creates an event.
Caller attendee handling
skills/lark-calendar/references/lark-calendar-create.md
The API guidance requires manually adding the caller’s open_id and merging and deduplicating attendees.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: documentation

Suggested reviewers: liangshuo-1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the summary, changes, verification, and related issues sections with clear details relevant to this documentation-only PR.
Title check ✅ Passed The title clearly and concisely describes the calendar documentation change for identity selection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/calendar-identity-pronoun-mapping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@fda9ce15148e8d072891950c4a99362149e445e2

🧩 Skill update

npx skills add larksuite/cli#docs/calendar-identity-pronoun-mapping -y -g

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.47%. Comparing base (a18ccd6) to head (fda9ce1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
+ Coverage   76.44%   76.47%   +0.02%     
==========================================
  Files        1013     1013              
  Lines      111957   112079     +122     
==========================================
+ Hits        85588    85707     +119     
  Misses      19859    19859              
- Partials     6510     6513       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calendar-assistant
calendar-assistant force-pushed the docs/calendar-identity-pronoun-mapping branch from 3924988 to 3b6cdde Compare August 11, 2026 07:48
@calendar-assistant calendar-assistant changed the title docs(calendar): clarify user/bot pronoun-to-identity mapping docs(calendar): clarify identity selection for scheduling Aug 11, 2026
@calendar-assistant
calendar-assistant force-pushed the docs/calendar-identity-pronoun-mapping branch from 3b6cdde to 5be74fa Compare August 11, 2026 07:55
Agents misread colloquial pronouns when creating events. Two fixes in
the calendar skill:

- SKILL.md: pronouns that are field values (attendees, meeting owner)
  do not participate in `--as` identity selection, so "会议 owner 为我"
  no longer flips bot-identity creation to user identity. "我" = the
  logged-in user, "你" = the application (bot).
- create.md: the raw calendar events/attendees API does not auto-add the
  calling identity as +create does; guide callers to add the caller's
  open_id as a user attendee when using the full API flow.
@calendar-assistant
calendar-assistant force-pushed the docs/calendar-identity-pronoun-mapping branch from 5be74fa to fda9ce1 Compare August 11, 2026 08:37
@calendar-assistant
calendar-assistant merged commit a80c810 into main Aug 11, 2026
40 of 56 checks passed
@calendar-assistant
calendar-assistant deleted the docs/calendar-identity-pronoun-mapping branch August 11, 2026 08:55
@liangshuo-1 liangshuo-1 mentioned this pull request Aug 11, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants