Show the plans and welcome-back cards on pages that ship no JS - #148
Merged
Conversation
/pro, /welcome-back and the legal pages export csr = dev, so in production they are static HTML with no client bundle. The two cards that landed there in #147 started hidden for a scroll reveal and had no script to show them; the dev server, which does ship JS, hid the bug. The reveal comes off those two cards, and the plan cards only start hidden on the homepage. Checked on the prerendered output: no data-reveal left in pro.html or welcome-back.html. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #147:
/proand/welcome-backexportcsr = dev, so production ships no JS there. The two new cards started hidden for a scroll reveal and nothing ever showed them; the dev server (which does ship JS) hid the bug.Fix: no reveal on those two cards; the plan cards only start hidden on the homepage. Verified on the prerendered output:
data-revealcount is 0 inpro.htmlandwelcome-back.html, 14 on the homepage as before.🤖 Generated with Claude Code