Fix leader election worker thread not running as daemon#2620
Fix leader election worker thread not running as daemon#2620archy-rock3t-cloud wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: archy-rock3t-cloud The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @archy-rock3t-cloud! |
Signed-off-by: Artem Muterko <artem@sopho.tech>
a413a1f to
6ab42f5
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
The leader election worker thread was created without
daemon=True; the precedingthreading.daemon = Trueonly sets an unused attribute on the threading module. It is now created withdaemon=Trueso it does not block interpreter shutdown.Which issue(s) this PR fixes:
Fixes #2619
Does this PR introduce a user-facing change?