fix(T12106): verify warns when session-free; complete's session error names the remedy - #1204
Merged
Merged
Conversation
… names the remedy gh#1194: verify is session-free by design (T9505 crash-recovery re-attestation), but nothing signalled that complete would refuse with E_CLEO_SESSION_REQUIRED, so agents misread the failure as an evidence problem. Verify now emits W_NO_ACTIVE_SESSION through the envelope meta.warnings channel (stdout stays pure), and requireActiveSession takes a remedy note — complete's error names 'cleo session start' and states recorded gates are preserved and need no re-verification. Closes #1194.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1194 —
cleo verifyaccepts evidence with no active session by design (T9505 crash-recovery re-attestation: the override-cap block explicitly falls back to a'global'bucket for session-less callers), but nothing signalled thatcleo completewould then refuse withE_CLEO_SESSION_REQUIRED. The reporter burned a cycle re-checking gate state, misreading a session problem as an evidence problem.Kept verify session-free; fixed the signaling on both sides:
warnIfNoActiveSessionpushes aW_NO_ACTIVE_SESSIONwarning through the canonical envelopemeta.warnings[]channel (stdout JSON stays pure) — strict-enforcement mode only, naming the remedy and that gates are preserved.requireActiveSessiongained an optional remedy note; complete's error now namescleo session startand states recorded gates do not need re-verification — recovery is "start a session, re-run complete" (idempotent per T12102).Verification (targeted only)
tsc --noEmitclean · biome cleanTask: T12106