perf: compile regex patterns once instead of per-call in hot paths - #1098
Open
myukitty wants to merge 1 commit into
Open
perf: compile regex patterns once instead of per-call in hot paths#1098myukitty wants to merge 1 commit into
myukitty wants to merge 1 commit into
Conversation
Signed-off-by: myukitty <myukittyy@gmail.com>
myukitty
force-pushed
the
perf/compile-regex-once
branch
from
August 17, 2026 17:45
d65036d to
992d010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing filters, Git commits, and Jira issue keys in loops or hot paths, compiling regular expressions on every iteration introduced unnecessary CPU and memory allocation overhead.
This PR:
ResourceFilterOptions: Lazily compiles and caches include/exclude regexes usingsync.Once, making concurrentShouldIncludecalls thread-safe and fast.GitView: AddsMatchRegexpInCommitMessageORBranchName(re *regexp.Regexp, ...)accepting a precompiled regex while maintaining backward-compatibleMatchPatternInCommitMessageORBranchName(pattern, ...).Jira: Pre-compiles and caches Jira key patterns in a thread-safesync.Map(getJiraKeyRegex) so both default and custom project key patterns avoid per-call compilation inFindJiraIssueKeys.internal/filters/resourceFilter_test.go,internal/jira/jira_test.go, andinternal/gitview/gitView_test.go.Fixes #826.