fix: correct ordering on revisions selector on hardware page#1937
Open
gustavobtflores wants to merge 1 commit into
Open
fix: correct ordering on revisions selector on hardware page#1937gustavobtflores wants to merge 1 commit into
gustavobtflores wants to merge 1 commit into
Conversation
gustavobtflores
added
the
Backend
alanpeixinho
approved these changes
Jun 16, 2026
| } | ||
| ) | ||
|
|
||
| for tree in trees: |
Contributor
There was a problem hiding this comment.
nit: because the difference might be negligible, but with this, we might want to remove the order by on the database query
Contributor
Author
There was a problem hiding this comment.
The ordering in the query is different from what we want (newest-first) and is needed for the DISTINCT ON, we could move all the ordering to the query, but it would increase complexity a little
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inconsistent ordering in the hardware page revision selector by sorting trees, branches, and revisions in the hardware selectors API response before returning them to the frontend.
How to test