Avoid extension install wait deadline race#300
Merged
Conversation
2cdd449 to
23e471f
Compare
sjmiller609
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Timing
Before this PR on the rebased public branch:
After this PR:
The Go e2e package runtime is now under 2.5m. The total e2e job is still above 2.5m because GitHub Actions setup plus the explicit image pull are counted around the Go test process.
The Docker context cleanup makes image builds more stable for test-only PRs by preventing e2e/test-only files from invalidating runtime image builder layers.
Validation
Follow-up for Cursor Bugbot feedback on #299.
Note
Low Risk
Changes are limited to e2e test timing, GitHub Actions workflow, and Docker ignore rules with no production runtime or auth logic touched.
Overview
Fixes a deadline race in enterprise extension install polling:
waitForExtensionInstallednow usesnextExtensionInstallPollDelay(shorter sleeps when little time remains, skip sleep when past deadline) instead of a fixed 1s wait, with unit tests for the delay helper.CI / build speed: the server e2e job re-enables the Go module cache (
server/go.sum) and pre-pulls headful and headless Chromium images in parallel beforemake test-e2e.Docker context:
.dockerignoreexcludesserver/e2e,server/**/*_test.go, andserver/**/testdataso test-only changes do not invalidate runtime image build layers.Reviewed by Cursor Bugbot for commit 46007d2. Bugbot is set up for automated code reviews on this repo. Configure here.