Adopt kernel-go-sdk v0.72.0; add extensions get + telemetry events; drop pool save_changes#192
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…rop pool save_changes - Bump kernel-go-sdk to v0.72.0. Adapts APIKeyService.Get (now takes APIKeyGetParams) and the browser-pool profile change in kernel/kernel#2484. - New `extensions get <id-or-name>`; new `browsers telemetry events <id>` (paged historical read with X-Next-Offset); new `--replay` on `browsers telemetry stream` (mutually exclusive with --seq). - Browser pools now have their own profile type (BrowserPoolProfile, id/name only, no save_changes; kernel/kernel#2484): drop `--save-changes` from `browser-pools create`/`update`, replace buildProfileParam with resolvePoolProfile (id/name selection, same validation), and drop the save-changes line from the pool profile display. Single-session `browsers create` keeps `--save-changes` (unchanged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
IlyaasK
force-pushed
the
sdk-v0.70.0-adoption
branch
from
f327c67 to
d187a2d
Compare
IlyaasK
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d187a2d. Configure here.
- Use the shared addJSONOutputFlag for `browsers telemetry events` instead of a
hand-rolled --output flag (consistency with extensions get). [Bugbot]
- Don't send --since/--until when --offset is set: offset is an opaque
X-Next-Offset cursor that already encodes the query window, so the window
flags are ignored when paging. Aligns behavior with the flag help and updates
--until's help to match --since. Added a test. [Bugbot]
- Surface the pagination cursor in JSON mode: `--output json` now emits
{"events": [...], "next_offset": "..."} so scripted callers can paginate
(table mode already printed the hint). Updated the empty-JSON test. [Bugbot]
- README: document `extensions get`, `browsers telemetry events`, and the
`--replay` flag on `telemetry stream`. [review]
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…is ignored) The SDK/API contract is: when offset is set, since is ignored but until still bounds the page. The previous commit over-dropped both — restore --until on the offset path and revert the --until help note. Test asserts since omitted / until kept under --offset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…e is ignored) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Per the SDK contract (Events: 'pass X-Next-Offset and repeat while X-Has-More is true'), gate the next-page cursor on X-Has-More rather than inferring it from a non-zero X-Next-Offset, which the server may still emit on the terminal page. Applies to both the JSON next_offset envelope and the table hint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sayan-
approved these changes
Jun 26, 2026
Sayan-
left a comment
Sayan-
left a comment
Contributor
There was a problem hiding this comment.
lightweight correctness review — build/vet/test green, traced each change against the v0.72.0 SDK types. no correctness bugs.
verified:
- pool profile rewiring (resolvePoolProfile): Profile is omitzero value struct, ID/Name are param.Opt[string]; unset → omitted, matches old nil guard. no regression on create/update.
- save_changes removal scoped correctly — dropped only on pool path (new BrowserPoolProfile has no such field); single-session browsers create/update keeps --save-changes.
- telemetry events: Ts is unix micros → time.UnixMicro correct; union Category/Type/Ts fields valid; zero LastUsedAt → FormatLocal returns -.
- api-keys get param threading + --replay/--seq mutual exclusion correct.
behavior changes (intentional, acknowledged):
- --save-changes removed from browser-pools create/update is a breaking CLI flag change — worth a release note.
- projects get now relies on server-side name resolution (kernel/kernel#2455); confirm that's live in prod to avoid a 404 on version skew.
- minor: telemetry events --output json doesn't surface the X-Next-Offset cursor (table-only), so scripted consumers can't page — not a regression.
yeet 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopt
kernel-go-sdkv0.72.0 and consume the new surface; also dropsave_changesfrom the browser-pool path now that v0.72.0 ships it.Changes
kernel-go-sdk→ v0.72.0. AdaptsAPIKeyService.Get(now takesAPIKeyGetParams).projects getresolves id-or-name server-side (kernel/kernel#2455); drops the client-side list-and-match.extensions get <id-or-name>— metadata, table +--output json.browsers telemetry events <id>— paged historical read (--limit/--offset/--since/--until), surfaces theX-Next-Offsetcursor.--replayonbrowsers telemetry stream(--replay=all, mutually exclusive with--seq).--save-changesfrombrowser-pools create/update. v0.72.0 gives browser pools their own profile type (BrowserPoolProfile, id/name only, nosave_changes; kernel/kernel#2484). ReplacedbuildProfileParamwithresolvePoolProfile(same id/name validation, no save_changes), and dropped the save-changes line from the pool profile display. Single-sessionbrowsers createkeeps--save-changes.Tests
go build/go vet/go test ./...all pass. Existing pool tests stay green (none referenced pool save_changes).🤖 Generated with Claude Code
Note
Low Risk
Mostly additive CLI features and SDK signature updates; pool profile change removes a flag users may have relied on for pools only.
Overview
Bumps
kernel-go-sdkto v0.72.0 and wires up new SDK APIs plus a few CLI behavior fixes.New commands:
extensions get <id-or-name>(metadata table / JSON) andbrowsers telemetry events <id>for paged historical telemetry (--limit,--offset,--since,--until), includingnext_offsetfromX-Next-Offsetin JSON mode.browsers telemetry streamgains--replay=all(replay buffered events from the oldest; exclusive with--seq).Browser pools: Removes
--save-changeson create/update now that pools use id/name-only profiles;resolvePoolProfilereplacesbuildProfileParam, and pool profile display no longer mentions save changes. Single-sessionbrowsers createstill supports--save-changes.SDK alignment:
api-keys getpassesAPIKeyGetParams{};projects getsends the identifier straight to the API (id or name) instead of client-side list resolution.README documents the new flags/commands and trims pool profile flag docs.
Reviewed by Cursor Bugbot for commit 89dfaff. Bugbot is set up for automated code reviews on this repo. Configure here.