fix(test): e2e suite silently skips every test - #2585
Open
ekam-walia wants to merge 6 commits into
Open
Conversation
Author
|
@jjamroga, made the suitable changes PTAL |
EItanya
approved these changes
Aug 26, 2026
Contributor
|
You need to avoid running the e2e tests in the unit tests job |
Contributor
|
And sign the DCO |
Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com>
ekam-walia
force-pushed
the
test-e2e-grpc-not-set
branch
from
August 27, 2026 02:45
4dbe7a7 to
14b87a6
Compare
Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com>
EItanya
reviewed
Aug 27, 2026
EItanya
left a comment
EItanya
left a comment
Contributor
There was a problem hiding this comment.
SOrry, but can we re-add TestE2E to the prefix of the e2e tests like we had before. Build tags can be a little annoying locally
Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com>
ekam-walia
force-pushed
the
test-e2e-grpc-not-set
branch
from
August 27, 2026 11:27
10721f8 to
62f65e6
Compare
Author
|
Hi @EItanya, made the reqd changes PTAL |
Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com>
Contributor
|
Unit tests are still failing |
Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com>
ekam-walia
force-pushed
the
test-e2e-grpc-not-set
branch
from
August 27, 2026 16:51
d3f532b to
5e8db37
Compare
Author
Just made the changes, tests should work properly now |
EItanya
approved these changes
Aug 27, 2026
Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com>
ekam-walia
force-pushed
the
test-e2e-grpc-not-set
branch
from
August 27, 2026 18:16
ad931eb to
b640a86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes is the fix of issue #2580
I have changed t.Skip() to t.Fatalf() so the test fails loudly when the environment variable is missing. CI already sets KAGENT_GRPC_URL as a fallback (line 142 in .github/workflows/ci.yaml), so CI continues to work.
Fixes #2580