feat(compiler): deep-review orchestration — 12 OpenSpec changes - #242
Open
julia-script wants to merge 55 commits into
Open
feat(compiler): deep-review orchestration — 12 OpenSpec changes#242julia-script wants to merge 55 commits into
julia-script wants to merge 55 commits into
Conversation
… Graph.stronglyConnected
…d compareAccess/requirementSatisfies
…nker removal, preserve catch causes
…egration/compiler-review
…/import into table
…ler-review-unified
…nt/compiler-review-unified
…iler-review-unified
…ip, mark task progress
Two equal fingerprint samples could accept a writer paused after truncation. Require two confirmations and pass the loaded project snapshot directly to the watched build or check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiler Deep-Review — Unified Orchestration PR
Combines all 12 OpenSpec changes from the compiler deep-review orchestration into a single reviewable branch. Supersedes #230–#241.
Wave A — Foundation
remove-compiler-dead-code (17 files, −300 lines)
Deletes nine zero-caller Analysis exports, dead serializers and guards (IntrinsicAvailability.encode, Type.isOutOfMemoryError, Type.intrinsicConformances/intrinsicallyConforms, OsRuntime.isSymbol, CallableFieldRealization narrowers, OpaqueRealization.publicOrigin), dead IR walkers (SuspensionMir.hasSuspension, Hir.hasUnavailable, Mir.suspensionControlEdges), ModuleTooling.make, DeclarationIndex.presentParameterNameEntries alias, FrontendTooling re-exports, and the eager SyntaxCorrespondence call from ProjectAnalysis. Drops the effect/Option import from Mir.ts.
extract-compiler-shared-helpers (7 new internal modules)
internal/ByteClass.ts— unified ASCII byte classifiers, routed through Lexer, LiteralForm, IntegerLiteralinternal/Align.ts— onealignUp, routed through Layout, Backend, WasmBackend, CoroutineFrameinternal/Graph.ts— parameterized Tarjan SCC, ModuleClosure routed through itinternal/Escape.ts— escape vocabulary, LiteralForm scalarCount extractedImportPath.spelling()— unified import-path rendering, routed through ModuleSummary, ImportPlan, ModuleClosureFloatingPoint.canonicalNaN()— single canonical NaN constant, routed through Transcendental, fromNumber, squareRootBackend.suspensionPointKey— exported from Backend, WasmBackend duplicate deletedWave B — Semantic + Boundary
reconcile-compiler-duplicated-semantics
Exports
Type.accessRank, addsType.compareAccessandType.requirementSatisfies. Routes TypeCompatibility, InterfaceWitnessCompatibility, and Type.ts internal sites through the shared helpers. Fixes the exact-only requirement access check in Type.ts (now uses Shared < Exclusive ordering). Createsinternal/SetOf.tswith equal/union/intersection, routes Ownership and SuspensionOwnership set helpers through it. AddsType.someSubterm(boolean fold over Type). AddsOwnership.inReleaseOrder(LIFO release-order helper), routes SuspensionOwnership through it. FixesToken.describe('Invalid')wording.harden-compiler-native-boundary
Replaces RangeError throw with BackendError yield in WasmBackend codegen. Removes the never-injected NativeLinker interface. Preserves error cause in BootstrapEvaluation HostWrite and OsCall catch blocks. Removes
as SyntaxTree.Nodecasts from Elaboration.ts.Wave C — Eight Splits
Each split establishes the module structure its proposal calls for:
internal/TypeInference.tsinternal/CleanupPlan.tsinternal/CallingShape.tsinternal/MirSuspension.tsinternal/DeclarationFacts.tsinternal/BackendShared.tsVerification
pnpm typecheckpnpm exec biome check .pnpm test:parallelFiles changed
101 files, +1554/−536 lines