fix(Combobox): keep filter after blur when input has search term - #1169
Open
Steve0x2a wants to merge 1 commit into
Open
fix(Combobox): keep filter after blur when input has search term#1169Steve0x2a wants to merge 1 commit into
Steve0x2a wants to merge 1 commit into
Conversation
Signed-off-by: Yi Zhan <stevesough@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @patorelovsky.
Typing a non-matching Combobox filter (for example
asdf) correctly shows "The filter returned no results". Closing with the caret keeps that filter, but blurring (click outside) clearedshouldFilterwhile leaving the input text in place. Reopening then showed the full list.On blur, only clear
shouldFilterwhen the input has no search term, so leftover text keeps the filtered list.Fixes #1164