Skip to content

Allow '.' in usernames - #341

Merged
Eccenux merged 1 commit into
jenkinsci:masterfrom
buminks:master
Sep 1, 2026
Merged

Allow '.' in usernames#341
Eccenux merged 1 commit into
jenkinsci:masterfrom
buminks:master

Conversation

@buminks

@buminks buminks commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

Allow '.' in a username as valid character in exclude username filter.

The same kind of change was done in #233.

Testing done

mvn verify is running without errors.

before the change:
image

after the change:
image (1)

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Eccenux

Eccenux commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

+1 from me.

It should work with basic auth which is implemented in (dot should work in any encoding):
svnkit\src\main\java\org\tmatesoft\svn\core\internal\io\dav\http\HTTPBasicAuthentication.java

Fine in NTLM too
https://learn.microsoft.com/en-us/previous-versions//cc722458(v=technet.10)?redirectedfrom=MSDN

User names cannot contain certain characters. Invalid characters include:
" / \ [ ] : ; | = , + * ? < >
User names can contain all other special characters, including spaces, periods, dashes, and underscores. But it's generally not a good idea to use spaces in account names.

@Eccenux Eccenux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Eccenux
Eccenux merged commit 4f87d54 into jenkinsci:master Sep 1, 2026
15 checks passed
@buminks

buminks commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@Eccenux Thanks for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants