intN: name the actual type in the out-of-range OverflowError - #403
Open
EylonKrause wants to merge 1 commit into
Open
EylonKrause wants to merge 1 commit into
EylonKrause wants to merge 1 commit into
Conversation
The message was a constant that always said "int4", so an out-of-range uint4/int2/uint2/int1/uint1 value reported the wrong type. Format it with the type's name instead, and check the name in testCastFailure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The out-of-range message in the intN scalar/
setitemconversion is a constant that always saysint4:Format it with the type's
kTypeNameinstead (... cannot be converted to uint4), and havetestCastFailurecheck the name for the Python float, NumPy float and NumPy integer paths. No behaviour change otherwise;intn_test.pyand the rest of the suite pass.Disclosure: this contribution was authored with an AI coding assistant (Claude) and reviewed before submission.
🤖 Generated with Claude Code